test: remove racy node startup from execution test

[Radovenchyk]

node.Run was not needed - bc.Executor is set during node creation, before Run is called. Removed node.Run, waitForNodeInitialization, and the grace period sleep to eliminate the race condition

Summary by CodeRabbit

• Tests
  • Simplified executor test flow by removing unnecessary node lifecycle management from the test suite.

[coderabbitai]

📝 Walkthrough

Walkthrough

The TestBasicExecutionFlow test in node/execution_test.go was simplified by removing node startup and shutdown control logic. The test no longer manages goroutines, contexts, or initialization waiting; it now focuses directly on executor functionality testing with an already-constructed node.

Changes

Cohort / File(s)	Summary
Test Simplification node/execution_test.go	Removed explicit node lifecycle management (goroutine spawning, context cancellation, initialization wait loop) and deleted the waitForNodeInitialization helper function and unused errors import. Test now directly tests executor methods on a pre-constructed node.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 One test was cluttered, now it's lean,
No more goroutines muddying the scene,
The executor shines without the fuss,
Simpler tests bring joy to us! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description check	✅ Passed	The description provides a clear explanation of why changes were made (eliminating race condition) but lacks the structured format recommended by the template, which requests an Overview section with context, background, goal, and rationale.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check	✅ Passed	The pull request title clearly and concisely describes the main change: removing racy node startup logic from an execution test file to fix a race condition.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[julienrbrt]

utACK

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.28%. Comparing base (4c7323f) to head (3f6b681).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3264      +/-   ##
==========================================
- Coverage   62.33%   62.28%   -0.06%     
==========================================
  Files         122      122              
  Lines       12877    12877              
==========================================
- Hits         8027     8020       -7     
- Misses       3970     3974       +4     
- Partials      880      883       +3     

Flag	Coverage Δ
combined	62.28% <ø> (-0.06%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.