Skip to content

Fix base-uri() returning empty string instead of the document path #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Laurettta wants to merge 2 commits into
base: develop-7.x.x
Choose a base branch
from
Open

Fix base-uri() returning empty string instead of the document path #204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a313b7
[bugfix] base-uri() was returning empty string instead of the documen…
Laurettta May 1, 2026
dd6bd42
[test] Make getBaseURI tests cross-platform
Laurettta May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 7 additions & 15 deletions exist-core/src/main/java/org/exist/dom/memtree/DocumentImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1658,26 +1658,18 @@ public XQueryContext getContext() {

@Override
public String getBaseURI() {
final Element el = getDocumentElement();
if(el != null) {
final String baseURI = getDocumentElement().getAttributeNS(Namespaces.XML_NS, "base");
if(baseURI != null) {
return baseURI;
}
}
final String docURI = getDocumentURI();
if(docURI != null) {
return docURI;
} else {
if(context!=null && context.isBaseURIDeclared()) {
try {
return context.getBaseURI().getStringValue();
} catch(final XPathException e) {
//TODO : make something !
}
}
if(context != null && context.isBaseURIDeclared()) {
try {
return context.getBaseURI().getStringValue();
} catch(final XPathException e) {
//TODO : make something !
}
return XmldbURI.EMPTY_URI.toString();
}
return XmldbURI.EMPTY_URI.toString();
}

@Override
Expand Down
30 changes: 30 additions & 0 deletions exist-core/src/test/java/org/exist/dom/memtree/DocumentImplTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,36 @@ public void testGetInScopePrefix() throws IOException, ParserConfigurationExcept
assertEquals(Namespaces.XHTML_NS, namespaceUri);
}

@Test
public void getBaseURI_withDocumentURI() throws IOException, SAXException, ParserConfigurationException {
final DocumentImpl doc;
try(final InputStream is = new UnsynchronizedByteArrayInputStream("<root/>".getBytes(UTF_8))) {
doc = parseExist(is);
}
doc.setDocumentURI("file:///intranet/xsl/template.xsl");
assertEquals("file:///intranet/xsl/template.xsl", doc.getBaseURI());
}

@Test
public void getBaseURI_ignoresXmlBaseOnRoot() throws IOException, SAXException, ParserConfigurationException {
final DocumentImpl doc;
try(final InputStream is = new UnsynchronizedByteArrayInputStream(
"<root xml:base=\"http://example.org/\"/>".getBytes(UTF_8))) {
doc = parseExist(is);
}
doc.setDocumentURI("file:///intranet/xsl/template.xsl");
assertEquals("file:///intranet/xsl/template.xsl", doc.getBaseURI());
}

@Test
public void getBaseURI_noDocumentURI() throws IOException, SAXException, ParserConfigurationException {
final DocumentImpl doc;
try(final InputStream is = new UnsynchronizedByteArrayInputStream("<root/>".getBytes(UTF_8))) {
doc = parseExist(is);
}
assertEquals("", doc.getBaseURI());
}

private Document parseXerces(final InputStream is) throws ParserConfigurationException, SAXException, IOException {
final DocumentBuilderFactory factory = DocumentBuilderFactory.newInstance();
factory.setNamespaceAware(true);
Expand Down
Loading