Skip to content

fix: support request-scoped rollout logging config#449

Merged
xzrderek merged 1 commit intomainfrom
derek/request-scoped-ts-rollout-logger
Apr 29, 2026
Merged

fix: support request-scoped rollout logging config#449
xzrderek merged 1 commit intomainfrom
derek/request-scoped-ts-rollout-logger

Conversation

@xzrderek
Copy link
Copy Markdown
Contributor

@xzrderek xzrderek commented Apr 29, 2026

Summary

  • Add request-scoped gatewayBaseUrl and apiKey support to the TypeScript Fireworks logging transport.
  • Extend createRolloutLogger to accept an options object while preserving the existing string-name call shape.
  • Keep API keys inside the transport instance rather than attaching them to log metadata.

Test plan

  • npx tsc --noEmit from typescript/

Made with Cursor


Note

Cursor Bugbot is generating a summary for commit c4aa43a. Configure here.

Allow TypeScript rollout loggers to use per-request gateway URLs and API keys so remote rollout servers can log status to the same tracing environment used for model calls.

Made-with: Cursor
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit c4aa43a. Configure here.

waitUntil: (promise: Promise<any>) => globalWaitUntil?.(promise)
})
]
});
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicated logger configuration will drift over time

Low Severity

The logger configuration inside createRolloutLogger (level, format, console transport) is a near-exact copy of the module-level logger configuration. If either copy is updated in the future (e.g., log level, format options, additional transports), the other will silently remain stale. Extracting shared config (format, level, console transport factory) into a reusable constant or helper would eliminate this risk.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit c4aa43a. Configure here.

@xzrderek xzrderek merged commit e7b69d2 into main Apr 29, 2026
17 checks passed
@xzrderek xzrderek deleted the derek/request-scoped-ts-rollout-logger branch April 29, 2026 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant