Conversation
akrem-chabchoub
left a comment
There was a problem hiding this comment.
Thanks @mfw78 for your contribution 💯.
We should also removed this from here:
https://github.com/ethersphere/beekeeper/blob/master/config/config.yaml#L200
|
@gacevicljubisa Not sure if we are using Kademlia check elsewhere ? because AFAIK if the check isn’t included in Bee CI, it doesn’t necessarily need to be removed from Beekeeper. |
akrem-chabchoub
left a comment
There was a problem hiding this comment.
@mfw78 There are some git confilicts
Yes, it is not used in CI. But many checks are used like cron jobs on our cluster. I guess Kademlia check is not used anywhere, maybe it can be removed? @acud any opinion? |
Summary
Remove the kademlia check which evaluates internal node data structures rather than hive behavior.
Rationale
Beekeeper is for testing hives
Beekeeper's purpose is to test the behavior of multiple swarm nodes working together as a hive. The kademlia check queries individual nodes'
/topologyendpoints and evaluates internal data structures (depth, bins, population). This does not test how nodes interact with each other as a swarm.Not used in CI
The kademlia check has never been included in bee's CI workflow. The actual CI checks used are:
ci-full-connectivity,ci-settlements,ci-pss,ci-soc,ci-gsoc,ci-pushsync-chunks,ci-pushsync-light-chunks,ci-retrieval,ci-manifest,ci-feed.Hive behavior is tested elsewhere
Actual hive connectivity and routing behavior is properly tested by:
fullconnectivity- verifies nodes can communicate via ping/pongpushsync/retrieval- verifies chunks route correctly through the swarmThese checks validate how nodes work together as a hive rather than internal implementation details of individual nodes.