Open
Conversation
|
|
snitin315
force-pushed
the
skip-ci-package-manager
branch
from
f9116da to
f8bc2eb
Compare
lumirlumir
requested changes
Feb 15, 2026
| # Skip on Release Please PRs | ||
| # https://github.com/eslint/rewrite/issues/366 | ||
| if: >- | ||
| !(github.event_name == 'pull_request' && contains(github.event.pull_request.title, 'chore: release')) |
Member
There was a problem hiding this comment.
Suggested change
| !(github.event_name == 'pull_request' && contains(github.event.pull_request.title, 'chore: release')) | |
| !(github.event_name == 'pull_request' && github.event.pull_request.user.login == 'eslintbot' && contains(github.event.pull_request.title, 'chore: release')) |
I think it would be helpful to add an extra check to verify whether the PR author is eslintbot. This would help avoid cases where a PR title contains chore: release but the author is someone else.
Also, based on the description in #366, it seems this workflow need to be prevented from running on the main branch for release-please commits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Fix #366
What changes did you make? (Give an overview)
I feel it's better to just skip the workflow than add complicated workarounds.
Related Issues
Fix #366
Is there anything you'd like reviewers to focus on?