Add a castom lint rule to check for duplicates, and eslint itself.#213
Closed
Cross-sama wants to merge 1 commit intoes-tooling:mainfrom
Closed
Add a castom lint rule to check for duplicates, and eslint itself.#213Cross-sama wants to merge 1 commit intoes-tooling:mainfrom
Cross-sama wants to merge 1 commit intoes-tooling:mainfrom
Conversation
43081j
reviewed
Jun 8, 2025
| schema: [], | ||
| }, | ||
| create(context) { | ||
| // only run once per lint run (on Program) |
Contributor
There was a problem hiding this comment.
this create will run per JS file
we should probably run against the JSON files and report the specific file/position while traversing it
that also means we'd need to setup eslint to be able to lint JSON, though.
i.e. it should visit each manifest and check against the already seen set, to then report the exact position in the current manifest being linted
Contributor
Contributor
|
we are going to stick with our scripts for now but may revisit eslint rules in future |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tried to fix issue discribed here:
#48