Slow Codex In Review - #2381
Draft
entire[bot] wants to merge 2 commits into
Draft
Conversation
…yntax Drops the 28-word paraphrase of `/review` in `entire review --agent codex`. Previously `expandCodexBuiltinReview` rewrote the literal `/review` token into "Review the current branch changes and report actionable findings..." before piping to `codex exec -`, which obscured the slash-command signal codex uses to route into its built-in review workflow. The composed prompt now passes through verbatim: `/review` reaches codex as a literal token, codex recognises it as a built-in slash-command and dispatches to its native review flow (which references the user's installed code-reviewer skill in ~/.codex/skills/ if present). Other context entire layers on top (always-prompt, per-run prompt, scope clause, checkpoint context) is also preserved verbatim. Multi-agent parallel smoke test against this branch: codex 3m31s — succeeded claude 2m29s — succeeded ratio 1.42x Down from the originally-reported 2-5x. Remaining gap is dominated by the user's local codex config (`model_reasoning_effort = "xhigh"`, `gpt-5.5`) plus codex's exec-mode exploration style rather than entire's composition. Note on rejected alternative: codex `exec review` would invoke the native subcommand more directly, but its CLI enforces mutual exclusion between `--base`/`--uncommitted`/`--commit` and `[PROMPT]`, and codex hooks don't fire during non-interactive `codex exec`, so there is no available channel to layer entire's user customization onto a native-subcommand run. The reviewer.go docstring documents this trade-off so future readers understand why we didn't take that route. Also fixes the picker's codex install hint in skilldiscovery/registry.go. The previous entry had two problems: `ProvidesAny` used claude-plugin syntax (`/codex:adversarial-review`) instead of codex's `@plugin-name` form, and the install command referenced `codex plugins add` (not a real codex subcommand). Updated to `@codex-review-pack` and `codex plugin marketplace add <url>`. AGENT.md gains a "Plugin / Skill Invocation" subsection documenting codex's actual `/`, `@`, `$` prefix system so this misconception doesn't recur. Version bump 0.116.0 -> 0.130.0 matches what's locally installed and what main's reviewer.go already documents. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Entire-Checkpoint: 06fcc2e0141d
Adds `review.codex.model` and `review.codex.reasoning_effort` settings fields that translate to codex CLI flags `-m <model>` and `-c model_reasoning_effort=<level>` on the spawn. Users who want faster `entire review --agent codex` can opt into lower reasoning effort (or a faster model) just for review, without changing their global `~/.codex/config.toml`. Verified empirically: lowering reasoning_effort from xhigh to low cuts average codex review wall-clock by ~2-3x on a 6-file diff, with no review-quality regression (same finding caught, marker prompt honored, codex still loads its `code-reviewer` skill). Variance remains high (codex's reasoning model decides exploration depth per-turn) but the distribution shifts lower. Plumbing: settings.ReviewConfig gains Model + ReasoningEffort fields; reviewtypes.RunConfig mirrors them; applyReviewConfig copies them across. buildCodexReviewCmd inserts the flags before the trailing `-` stdin marker, omitting them when empty so codex falls back to user config. Documents the perf characteristics in codex/AGENT.md including the reasoning_effort lever and how to inspect codex session rollouts when diagnosing slow runs. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Entire-Checkpoint: c3809ade3466
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://entire.io/gh/entireio/cli/trails/373
This draft pull request was opened by Entire after CI was requested for the linked trail. Feel free to edit the title or body — the link above is what keeps the trail and PR connected.