Fail E2E tasks when the test regex selects no tests - #2374
Open
gtrrz-victor wants to merge 3 commits into
Open
Conversation
Entire-Checkpoint: 01M27ZME7MXVQZ6QZDJ4VA0ZFB
Contributor
There was a problem hiding this comment.
馃煛 Changes recommended
The critical reporter issue remains unresolved for incomplete non-terminal test events.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Fixes false-green E2E runs when a test regex selects no tests.
Changes:
- Adds opt-in
-fail-on-emptyreporting withNO TESTS RAN. - Updates E2E tasks to preserve failures and generate reports.
- Adds regression tests and documentation.
File summaries
| File | Summary |
|---|---|
mise-tasks/test/e2e/roger-roger |
Handles empty selections while preserving test failures. |
mise-tasks/test/e2e/canary |
Runs and reports both canary agents. |
mise-tasks/test/e2e/_default |
Handles reporter status and missing version metadata. |
e2e/README.md |
Documents empty-selection behavior. |
e2e/cmd/testreport/main.go |
Implements strict reporting; incomplete non-terminal events may still be counted as passed. |
e2e/cmd/testreport/main_test.go |
Adds reporter regression coverage. |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 1
- Review effort level: Lite
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
# Conflicts: # e2e/README.md
Entire-Checkpoint: 01M282N7JK011V94EH9YPR22ND
gtrrz-victor
marked this pull request as ready for review
September 11, 2026 11:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://entire.io/gh/entireio/cli/trails/1307
Summary
An E2E regex matching no tests made gotestsum exit successfully and the reporter print
ALL 0 TESTS PASSED. The existing E2E mise tasks now fail that selection after writing their reports. Truncated event streams with no completed parent tests also fail instead of reporting success.What Changed
-fail-on-emptyreporter flag. Only terminal parentpass,fail, orskipevents satisfy it. Skipped tests still count, and a retry needs its own terminal event.NO TESTS RANfor empty input and an incomplete count andINCOMPLETEbanner for unfinished tests. Mixed completed and incomplete results never claim all tests passed; the strict flag only rejects zero completed parents.A regex that matches a top-level parent but no subtests is outside this change.
Verification
mise run lintpassed with the pinned golangci-lint 2.13.2.mise run test:cipassed after the review fix, including unit and integration tests with the race detector and both deterministic canary agents. No paid agent calls were made.