Add option to keep the same method for 301/302 redirects - #3783
Open
kajinamit wants to merge 1 commit into
Open
Conversation
RFC hasn't been clear enough about the expected behavior for 301 and 302 response. While it's (unfortunately) common for browsers to switch the original http method to GET when following redirects, some server applications expects the "legacy" behavior which keeps the same method over redirects. Add new option to clients to select the behavior. Signed-off-by: Takashi Kajinami <kajinamit@oss.nttdata.com>
11 tasks
imbdb
approved these changes
Sep 12, 2026
imbdb
left a comment
imbdb
left a comment
There was a problem hiding this comment.
Thank you for this PR. Looks good to me.
Helps in getting around these non standard conventions.
imbdb
reviewed
Sep 12, 2026
| if response.status_code == codes.SEE_OTHER and method != "HEAD": | ||
| method = "GET" | ||
|
|
||
| if self.keep_method_for_redirects: |
There was a problem hiding this comment.
If you are targeting 301/302, Please make them explicit in the condition and also add a comment for this behavior change for future humans/agents to understand the context.
imbdb
suggested changes
Sep 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RFC hasn't been clear enough about the expected behavior for 301 and 302 response. While it's (unfortunately) common for browsers to switch the original http method to GET when following redirects, some server applications expects the "legacy" behavior which keeps the same method over redirects.
Add new option to clients to select the behavior.
Checklist