Remove NODEJS_CATCH_REJECTION#26330
Merged
sbc100 merged 1 commit intoemscripten-core:mainfrom Feb 24, 2026
Merged
Conversation
sbc100
force-pushed
the
NODEJS_CATCH_REJECTION
branch
from
87fe918 to
abb3975
Compare
kripken
approved these changes
Feb 24, 2026
This settings only has an effect when targeting very old version of node (< 15). Its trivial to replace with a simple `--pre-js` file or with the `--unhandled-rejections=strict` command line flag which is basically emulates. Version of node above v15 have this behavior by default.
sbc100
force-pushed
the
NODEJS_CATCH_REJECTION
branch
from
abb3975 to
ba4adcb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This settings only has an effect when targeting very old version of node (< 15). Its trivial to replace with a simple
--pre-jsfile or with the--unhandled-rejections=strictcommand line flag which is basically emulates.Version of node above v15 have this behavior by default.