Remove NODEJS_CATCH_EXIT setting#26326
Merged
sbc100 merged 1 commit intoemscripten-core:mainfrom Feb 24, 2026
Merged
Conversation
dschuff
approved these changes
Feb 24, 2026
sbc100
force-pushed
the
NODEJS_CATCH_EXIT
branch
from
3e3aa35 to
6f62d34
Compare
kripken
reviewed
Feb 24, 2026
kripken
approved these changes
Feb 24, 2026
sbc100
force-pushed
the
NODEJS_CATCH_EXIT
branch
from
6f62d34 to
bbb98a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This setting has not been enabled by default since #22257.
It is not used anywhere internally in emscripten test suite anymore.
Its is problematic because it installs process-wide global exit handler (so it doesn't work well with other modules or other code).
It should not be needed in general since most code paths that enter the module are wrapped in try/catch that handled ExitStatus.
Its trivial to replace with a
--pre-jsor some other external JS snippet.