libwebsocket: add missing $webSockets dependency#26318
Merged
sbc100 merged 2 commits intoemscripten-core:mainfrom Feb 26, 2026
Merged
libwebsocket: add missing $webSockets dependency#26318sbc100 merged 2 commits intoemscripten-core:mainfrom
sbc100 merged 2 commits intoemscripten-core:mainfrom
Conversation
subhaushsingh
force-pushed
the
fix-websocket-deps
branch
3 times, most recently
from
bb5aca2 to
332a885
Compare
Contributor
Author
|
@sbc100 I've added a regression test for emscripten_websocket_new to cover the missing $webSockets dependency issue. |
kripken
approved these changes
Feb 23, 2026
sbc100
approved these changes
Feb 23, 2026
subhaushsingh
force-pushed
the
fix-websocket-deps
branch
from
332a885 to
b122d4f
Compare
Contributor
Author
|
Addressed review feedback:
Thanks for the thorough review! |
sbc100
reviewed
Feb 24, 2026
test/test_sockets.py
Outdated
|
|
||
| def test_websocket_new(self): | ||
| self.btest_exit('websocket/test_websocket_new.c', | ||
| cflags=['-lwebsocket']) |
Collaborator
There was a problem hiding this comment.
Can you combine these into a single line
sbc100
approved these changes
Feb 24, 2026
subhaushsingh
force-pushed
the
fix-websocket-deps
branch
from
b122d4f to
7b6cfb0
Compare
Contributor
Author
|
@kripken I've addressed all the requested changes. Could you take another look when you get a chance? Auto-merge is already enabled. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
emscripten_websocket_newuses$webSocketsbut does not declare it as a dependency.Fixes: #26310