Sanitize ExUnit formatters against invalid UTF-8 - #15821
Merged
josevalim merged 9 commits intoSep 1, 2026
Merged
Conversation
Member
|
I propose for us to first change only the cli formatter to escape logs indeed. Can you please amend accordingly? For the tests, we have an integration suite where we already check for capture logs, so we can add a single new test there. Thanks! |
Contributor
Author
|
Done, I wasn't able to find any path through which the regular captured logs wind up invalid, so I only added sanitization to the failure messages |
Member
|
Looks very clean now! |
Member
|
💚 💙 💜 💛 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe here the reasons behind the pull request.
This is a fix for a crash in ExUnit that I came across while debugging missing logs for a test suite that turned out to hit the already-fixed diff crashing the formatter: 0055f2fe53. Nevertheless it is reproducible as shown in this minimal mix project. I believe ExUnit fails on Ecto exception error #11108 might be related
Make sure you have read the CONTRIBUTING.md file.
✅
Make sure any relevant documentation and tests have been added/updated.
N/A
Do not submit Draft pull requests unless previously asked/agreed.
N/A
AI assistance
The tests were AI generated, I applied the fixes