Improve the OPFS-AHP error outside dedicated workers - #1079
Open
psh4607 wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
I looked into the failing WebKit check. The OPFS tests are passing consistently, while the failures are coming from the existing WebKit memory/IDB tests. I also found similar WebKit/WASM failures in unrelated CI runs before this PR and across different Node versions. The errors look similar to a previously reported JavaScriptCore issue affecting PGlite, although I haven't confirmed that it is the exact same underlying bug: I also reproduced the web suite using Ubuntu 22.04, Node 21.7.3, pnpm 9.7.0, and the same Playwright/WebKit version. The OPFS tests passed there as well. Given that, this failure appears unrelated to the change in this PR. Would it be okay to treat it as an existing WebKit CI issue and rerun or override the check? |
psh4607
marked this pull request as ready for review
August 13, 2026 00:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
작업 배경
OPFS-AHP depends on
FileSystemFileHandle.createSyncAccessHandle(), which is only exposed in Dedicated Web Workers. Using it from the main thread, a Shared Worker, or a Service Worker currently fails with a low-level error that does not explain the unsupported execution context.티켓 및 링크
작업 내용
테스트
pnpm --dir packages/pglite exec vitest run tests/opfs-ahp.test.tspnpm --dir packages/pglite stylecheckpnpm --dir packages/pglite typecheck