Skip to content

Fix PGlite.create options without a data directory - #1078

Open
psh4607 wants to merge 1 commit into
electric-sql:mainfrom
psh4607:fix/773-create-options
Open

Fix PGlite.create options without a data directory#1078
psh4607 wants to merge 1 commit into
electric-sql:mainfrom
psh4607:fix/773-create-options

Conversation

@psh4607

@psh4607 psh4607 commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

작업 배경

The PGlite.create overload permits passing undefined as the data directory and providing options as the second argument. The implementation previously discarded those options and silently used the defaults.

티켓 및 링크

작업 내용

  • Fall back to the second options argument when the data directory is undefined.
  • Add a regression test using the public debug option.
  • Add a patch changeset for @electric-sql/pglite.

테스트

  • pnpm --dir packages/pglite exec vitest run tests/instantiation.test.ts --reporter=dot
  • pnpm --dir packages/pglite typecheck
  • pnpm --dir packages/pglite stylecheck

@psh4607
psh4607 marked this pull request as ready for review August 12, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] PGlite.create's type definition and implementation do not match

1 participant