Update to .NET 10 / EF Core 10 by techiedesu · Pull Request #168 · efcore/EFCore.FSharp

techiedesu · 2026-04-05T05:10:58Z

Summary

Migrate EFCore.FSharp from .NET 6 / EF Core 6 to .NET 10 / EF Core 10
Update all dependencies (FSharp.Core, FSharp.Compiler.Service, paket, fantomas, FAKE)
Adapt library and test code to EF Core 10 breaking changes (removed/renamed APIs, new interface members, constructor changes)
Add C# interop project for TestRelationalTypeMappingSource (F# cannot handle C# covariant return types)
Update CI workflow, devcontainer, VS Code configs, and documentation for .NET 10
Replace deprecated PackageLicenseUrl with PackageLicenseExpression (MIT)
Relax FSharp.Core dependency constraint to >= 9.0.100

Checklist

I have followed the Contribution Guidelines
I have added tests (if appropriate)
I have added necessary documentation (if appropriate)

Test plan

All 84 existing tests pass on all platforms (ubuntu, windows, macOS)
Fantomas formatting check passes
NuGet package builds correctly with proper metadata (MIT license, net10.0 TFM)
End-to-end test: created sample F# project with EF Core migrations (scaffolding, applying, SQLite)
Devcontainer Docker image builds successfully
CI green on all 3 platforms

🤖 Generated with Claude Code

- global.json: SDK 6.0.100 -> 10.0.100 - All projects: net6.0/net5.0 -> net10.0 - Package version: 6.0.0-local001 -> 10.0.0-local001

- actions/checkout v2 -> v4 - actions/setup-dotnet v1.9.0 -> v4 - dotnet-version: 6.x -> 10.x - Rename "Setup .NET Core SDK" to "Setup .NET SDK" - Remove obsolete DOTNET_ROOT workaround comments

dotnet-tools.json: - paket: 6.0.13 -> 10.3.1 - fantomas-tool 4.5.6 -> fantomas 6.3.15 - reportgenerator: 4.2.15 -> 5.4.1 paket.dependencies: - FSharp.Core: 6.0.1 -> 9.0.100 - Microsoft.EntityFrameworkCore.*: ~> 6.0.0 -> ~> 10.0.0 - FSharp.Compiler.Service: 41.0.1 -> 43.9.100 - FAKE: 5.20.4 -> 6.1.4 - Octokit: 0.48 -> >= 13.0.1 - Microsoft.NET.Test.Sdk: 17.0.0 -> 17.12.0

EntityFrameworkExtensions: - NamespaceComparer moved to Microsoft.EntityFrameworkCore.Design - Remove GetEntityTypeErrors (removed in EF Core 7) EFCoreFSharpServices: - ICSharpEntityTypeGenerator/ICSharpDbContextGenerator interfaces removed in EF Core 7; register concrete types directly FSharpHelper (ICSharpHelper interface): - Fragment: MethodCallCodeFragment -> IMethodCallCodeFragment - Add Fragment overloads: IMethodCallCodeFragment+indent, NestedClosureCodeFragment, PropertyAccessorCodeFragment, AttributeCodeFragment - Add Identifier<T> overload with IDictionary - Add Lambda(IEnumerable<IProperty>) overload - Add Literal: DateOnly, TimeOnly, BigInteger, List<T>, Dictionary - Literal(Enum) gains fullName parameter - Namespace: add ParamArray attribute - Add XmlComment, Arguments, GetRequiredUsings, Statement, Expression - Fix AppendLine(FormattableString) ambiguity with type annotation FSharpDbContextGenerator: - ISequence.ClrType -> .Type - Remove ScaffoldingAnnotationNames.EntityTypeErrors - Remove GetEntityTypeErrors loop - Convert ICSharpDbContextGenerator interface to member FSharpEntityTypeGenerator: - GetPropertiesAndNavigations -> GetMembers - Convert ICSharpEntityTypeGenerator interface to member FSharpModelGenerator: - Use concrete generator types instead of removed interfaces - ScaffoldedFile: named-param constructor -> positional constructor FSharpMigrationsScaffolder: - Save: add dryRun parameter, guard file writes - Fix File.WriteAllText ReadOnlySpan<char> overload ambiguity FSharpSnapshotGenerator: - Fragment(c, builderName) -> Fragment(c, builderName, false) (typeQualified parameter now required)

F# cannot handle C# covariant return types used by RelationalTypeMappingSource in EF Core 10 (new virtual methods with sealed bridge methods). The F# compiler doesn't see the bridge methods as implementing abstract members from TypeMappingSourceBase. Move TestRelationalTypeMappingSource to a C# project and have the F# test project reference it. Also update the F# stub to inherit from the C# base class and fix Clone -> WithStoreTypeAndSize rename.

Mocks.fs: - Add IHistoryRepository members: Create, CreateAsync, LockReleaseBehavior, AcquireDatabaseLock, AcquireDatabaseLockAsync SqlServerTestHelpers.fs, RelationalTestHelpers.fs: - UseProviderOptions now returns DbContextOptionsBuilder (was void in EF Core 6) FakeDbConnection.fs: - Remove AppendIdentityWhereCondition, AppendSelectAffectedCountCommand, AppendRowsAffectedWhereCondition (removed from UpdateSqlGenerator) BuildReference.fs: - Replace CompileToDynamicAssembly with Compile + Assembly.Load (CompileToDynamicAssembly removed in FSharp.Compiler.Service 43) - Shared FSharpChecker instance with lock for thread safety

FSharpMigrationOperationGeneratorTest: - SqlServerTypeMappingSource: pass SqlServerSingletonOptions() instead of Unchecked.defaultof (NRE in constructor) - WKTReaderType -> WktReaderType - Add namespace declaration to generated F# code - Type annotations for Assembly/MethodInfo reflection calls FSharpMigrationsGeneratorTest: - SqlServerSingletonOptions() for SqlServerTypeMappingSource - Filter RelationalAnnotationNames to string fields only - SortedDictionary -> Dictionary for DbFunctions - FinalizeModel: add skipValidation for annotation check tests - Update annotation exclusion lists with ~35 new EF Core 7-10 annotations (stored procedures, mapping strategies, JSON, etc.) - HasComment -> HasAnnotation for entity type comment - Remove DefiningQuery (removed in EF Core 7) - configure -> configureConventions parameter rename FSharpMigrationsScaffolderTest: - SqlServerSingletonOptions() for SqlServerTypeMappingSource - MigrationsModelDiffer dependencies: IChangeDetector -> IRelationalAnnotationProvider, IUpdateAdapterFactory -> IRowIdentityMapFactory - MigrationsScaffolder: add 4 new required dependencies - Save: add dryRun=false parameter ModelCodeGeneratorTestBase: - CreateConventionBuilder: use addServices parameter instead of passing stripped-down contextServices - Remove GetEntityTypeErrors call - FinalizeModel: remove skipValidation (use default validation)

- Changelog.New: add missing 5th parameter (references list) - Regex.IsMatch: add type annotation to resolve overload ambiguity

- Run fantomas on all source, test, and build files (48 files formatted) - Update SDK version requirements in README.md, GETTING_STARTED.md, and docsSrc/Tutorials/Getting_Started.md (.NET 5.0 -> 10.0) - Add CHANGELOG.md entry for 10.0.0 release

- Add explicit fantomas formatting settings to .editorconfig to prevent mass reformatting on future fantomas upgrades - Update .NET SDK download link to https://dotnet.microsoft.com/en-us/download

- Dockerfile: debian buster -> bookworm, update lib dependencies - install-dotnets.sh: remove hardcoded .NET 5.0, rely on global.json - devcontainer.json: extensions -> customizations.vscode.extensions - Remove deprecated FSharp.fsacRuntime setting from VS Code configs

- FSharp.Core: exact 9.0.100 -> >= 9.0.100 (fixes NU1608 warning when consumers use a newer FSharp.Core from their SDK) - Rename build/net5.0 -> build/net10.0 in NuGet package

- Fix hardcoded net6.0 TFM in docsTool/Program.fs (should be net10.0) - Move CSharpInterop project to paket (was using hardcoded preview EF Core version) - Update AssemblyInfo.fs files from 6.0.x to 10.0.0 - Replace deprecated PackageLicenseUrl with PackageLicenseExpression (MIT) - Replace failwith "todo" stubs with proper no-op implementations in FakeDiagnosticsLogger - Remove commented-out TryAddProviderSpecificServices dead code - Format docsTool/templates/types.fs with fantomas

techiedesu · 2026-04-05T05:22:56Z

@simon-reynolds @kant2002 could you review this? 👀

src/EFCore.FSharp/Scaffolding/FSharpEntityTypeGenerator.fs

Reverts mass-reformatting introduced by fantomas 6.3.15 upgrade. Formatting changes should be reviewed separately from functional .NET 10 migration changes as requested by reviewers.

techiedesu · 2026-04-06T14:19:44Z

Reverted all formatting changes. So sorry for formatting, my mistake 🙏

kant2002 · 2026-04-06T17:11:02Z

src/EFCore.FSharp/Internal/FSharpHelper.fs

        member this.Literal(value: string) : string = this.literalString value

+        member this.Literal(value: TimeOnly) : string =
+            if value.Ticks % 10_000L = 0L then


This looks like mistake

Good catch, fixed. Now follows the same logic as CSharpHelper.Literal(TimeOnly).

kant2002 · 2026-04-06T17:16:46Z

src/EFCore.FSharp/Scaffolding/FSharpEntityTypeGenerator.fs


            let nameMatches =
-                navigation.DeclaringEntityType.GetPropertiesAndNavigations()
+                navigation.DeclaringEntityType.GetMembers()


This looks like oversight and this will include fields and methods.

Oops. GetProperties + GetNavigations looks better

kant2002 · 2026-04-06T17:22:00Z

tests/EFCore.FSharp.Tests/Migrations/Design/FSharpMigrationsGeneratorTest.fs


        let rlNames =
            (typeof<RelationalAnnotationNames>).GetFields()
+            |> Seq.filter (fun f -> f.FieldType = typeof<string>)


Curious why this change is required?

api change

RelationalAnnotationNames now has a non-string AllNames field. GetFields() picks it up and the test breaks. Filter keeps only strings 🤷‍♀️

kant2002 · 2026-04-06T17:24:05Z

tests/EFCore.FSharp.Tests/Migrations/Design/FSharpMigrationsGeneratorTest.fs

                          _toTable
-                          + @"entityTypeBuilder.HasComment(""My Comment"") |> ignore"))
-                        (CoreAnnotationNames.DefiningQuery, (box (Expression.Lambda(Expression.Constant(null))), ""))
+                          + @"entityTypeBuilder.HasAnnotation(""Relational:Comment"", ""My Comment"") |> ignore"))


This looks like different test then original. No?

Yeah, different — old behavior doesn't work in EF Core 10. HasComment on entity is now obsolete, supposed to go inside ToTable(t => t.HasComment()). Updated generator and test to match.

techiedesu added 15 commits April 5, 2026 06:59

Update target frameworks and SDK to .NET 10

1e77431

- global.json: SDK 6.0.100 -> 10.0.100 - All projects: net6.0/net5.0 -> net10.0 - Package version: 6.0.0-local001 -> 10.0.0-local001

Update CI workflow for .NET 10

94c6fba

- actions/checkout v2 -> v4 - actions/setup-dotnet v1.9.0 -> v4 - dotnet-version: 6.x -> 10.x - Rename "Setup .NET Core SDK" to "Setup .NET SDK" - Remove obsolete DOTNET_ROOT workaround comments

Fix build script for .NET 10 API changes

168f690

- Changelog.New: add missing 5th parameter (references list) - Regex.IsMatch: add type annotation to resolve overload ambiguity

Pin fantomas settings in .editorconfig and fix .NET SDK download URL

88fb7b2

- Add explicit fantomas formatting settings to .editorconfig to prevent mass reformatting on future fantomas upgrades - Update .NET SDK download link to https://dotnet.microsoft.com/en-us/download

Relax FSharp.Core dependency and update NuGet build TFM

68652cf

- FSharp.Core: exact 9.0.100 -> >= 9.0.100 (fixes NU1608 warning when consumers use a newer FSharp.Core from their SDK) - Rename build/net5.0 -> build/net10.0 in NuGet package

Update CHANGELOG with complete list of 10.0.0 changes

d6d2118

Add CSharpInterop project to solution file

ff9b71b

Mark CSharpInterop as non-test project to fix CI

b047032

kant2002 reviewed Apr 6, 2026

View reviewed changes

src/EFCore.FSharp/Scaffolding/FSharpEntityTypeGenerator.fs Show resolved Hide resolved

Revert fantomas 6 formatting, downgrade to fantomas-tool 4.5.6

82dadf2

Reverts mass-reformatting introduced by fantomas 6.3.15 upgrade. Formatting changes should be reviewed separately from functional .NET 10 migration changes as requested by reviewers.

Remove non-functional changes from PR

3f66d37

techiedesu requested a review from kant2002 April 6, 2026 14:46

kant2002 reviewed Apr 6, 2026

View reviewed changes

Review fixes

5629902

techiedesu requested a review from kant2002 April 7, 2026 07:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to .NET 10 / EF Core 10#168

Update to .NET 10 / EF Core 10#168
techiedesu wants to merge 19 commits intoefcore:masterfrom
techiedesu:update-to-net10

techiedesu commented Apr 5, 2026

Uh oh!

techiedesu commented Apr 5, 2026

Uh oh!

Uh oh!

techiedesu commented Apr 6, 2026

Uh oh!

kant2002 Apr 6, 2026

Uh oh!

techiedesu Apr 7, 2026

Uh oh!

kant2002 Apr 6, 2026

Uh oh!

techiedesu Apr 7, 2026

Uh oh!

kant2002 Apr 6, 2026

Uh oh!

techiedesu Apr 7, 2026

Uh oh!

kant2002 Apr 6, 2026

Uh oh!

techiedesu Apr 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

Conversation

techiedesu commented Apr 5, 2026

Summary

Checklist

Test plan

Uh oh!

techiedesu commented Apr 5, 2026

Uh oh!

Uh oh!

techiedesu commented Apr 6, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants