Repository navigation
Add 383 source-only Microsoft regression tests - #562
elizabethmorrow wants to merge 2 commits into
Conversation
|
Important Review skippedToo many files! This PR contains 824 files, which is 674 over the limit of 150. To get a review, reduce the PR to 150 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. Usage-priced reviews support at most 500 files.
|
Import the passing subset with six supporting headers and 425 reviewed text recordings. Exclude binary-dependent tests, library snapshots, and 94 tests with nonpassing cases in either default configuration. The 383 tests pass all 415 cases in each default Docker configuration. No compiler sources or test infrastructure are changed. Related discussion: edgcpp#517 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 08e14ff2-ad6b-47ad-a0e1-fb79b758fb8d
e6308d2 to
d6e2e92
Compare
|
Thank you! It looks like either some tests have to be adapted to become target independent (e.g., use |
Use decltype(sizeof 0) for test 26337's size_t alias and remove the obsolete warning from its default recording. Preserve test 23765's unsigned-recursion trigger and record its legitimate 32-bit diagnostics. Add the eight required 32-bit C++-regeneration overrides without changing the original tests or 64-bit overrides. Verify all 383 tests / 415 cases in each of edg_x86_32, edg_x86_32_cp, edg_x86_64, and edg_x86_64_cp. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 08e14ff2-ad6b-47ad-a0e1-fb79b758fb8d
|
Addressed in
Docker validation at upstream |
Summary
Contribute the passing, source-only subset of the Microsoft regression tests
proposed in #517, following the
maintainer invitation to open a PR.
tests/tests/imported/microsoft, retaining the supplied numeric test IDs.importedsuite and positive/negative test expectations.configuration-specific overrides.
The numeric test IDs are not GitHub issue numbers. This PR references the
discussion; no separate issue has been identified.
Scope
Only source files and text recordings are included: no IFC binaries, DLLs,
executables, standard-library snapshots, or preprocessed library snapshots.
Tests depending on those artifacts or on Windows metadata are excluded.
Of the 477 source-only tests evaluated, 94 with nonpassing cases in either
default configuration are deferred rather than accepting failing baselines.
Import preparation normalizes UTF-8/LF source text and incidental trailing
whitespace. Small compatibility repairs replace an unsupported language option,
remove a misplaced BOM/nonbreaking spaces, repair a macro's final continuation,
and replace an obsolete cross-reference filter command with
edg-normalize-test-output.The portability follow-up changes test
26337'ssize_talias todecltype(sizeof 0)rather than assumingunsigned int. Its obsolete64-bit warning is removed from the default recording. Test
23765retainsits unsigned-recursion trigger, with separate 32-bit diagnostics reflecting
the correct
size_twraparound values. Eight additionaledg_x86_32_cprecordings exactly match the previously reviewed
edg_x86_64_cpoutputs:named configuration overrides do not inherit across target widths.
No test types or assertions are weakened, and no follow-up candidates are added.
Validation
Validated in Docker on November 20, 2026, using compiler sources at
upstream commit
69d1f4f22dfd9e89e4a89704c2c402855f114aceand this PR'supdated test/recording snapshot. Built
linux-gcc-debugandlinux-i686-gcc-debug, using each configuration's matching build environment:edg_x86_32edg_x86_32_cpedg_x86_64edg_x86_64_cpThe per-configuration environments were selected through
edg-prefix-env-loader. On Windows, the 32-bit build and test home were placedin container-native temporary storage to avoid Windows bind-mount inode
overflow; the standard build presets and compiler sources were not modified.
Reviewed all changed outputs, including expected-negative diagnostics, before
recording the ten affected tests with
-W. Restored the original suiteexpectation logs and confirmed the full non-recording rerun above: 1,660
passing cases and 1,668 matching command outputs. No failing baselines were
accepted. Submitted test/recording blobs are byte-identical to this validated
snapshot.
All 824 files were verified as UTF-8/LF text with no NUL bytes or binary diffs.
Source whitespace checks pass. Generated recordings retain the harness's
verbatim diagnostic spacing and final blank lines.