Repository navigation
Give co_await the value category of await_resume(). [GH #447] #542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mohitmishra786
wants to merge
1
commit into
edgcpp:main
Choose a base branch
from
mohitmishra786:gh-447-co-await-lvalue
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| [GH #447] | ||
| Value category of co_await and co_yield expressions | ||
|
|
||
| A co_await or co_yield expression was always treated as a prvalue, even | ||
| when the await_resume call returns a reference. It now has the value | ||
| category of the await_resume call, so code like this is accepted: | ||
|
|
||
| struct bool_ref_awaiter { | ||
| bool await_ready() noexcept; | ||
| void await_suspend(std::coroutine_handle<>) noexcept; | ||
| bool &await_resume() noexcept; | ||
| }; | ||
| task f() { | ||
| (co_await bool_ref_awaiter{}) = false; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| fe_only -DTEST_NUMBER=1 --c++23 Test_name.c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| //type:fp | ||
| //options:--c++23 | ||
| //remark:[GH #447] co_await has the value category of await_resume() | ||
| // | ||
| // A co_await or co_yield expression was always treated as a prvalue, so | ||
| // assigning to the result of an await_resume() that returns an lvalue | ||
| // reference was rejected. | ||
|
|
||
| namespace std { | ||
| template <typename = void> struct coroutine_handle; | ||
| template <> struct coroutine_handle<> { void *address(); }; | ||
| template <typename> struct coroutine_handle { | ||
| static coroutine_handle from_address(void *); | ||
| operator coroutine_handle<>() noexcept; | ||
| }; | ||
| template <typename R, typename...> struct coroutine_traits { | ||
| using promise_type = typename R::promise_type; | ||
| }; | ||
| template <class T, class U> struct is_same { static constexpr bool value = false; }; | ||
| template <class T> struct is_same<T, T> { static constexpr bool value = true; }; | ||
| } // namespace std | ||
|
|
||
| struct suspend { | ||
| bool await_ready() noexcept; | ||
| void await_suspend(std::coroutine_handle<>) noexcept; | ||
| void await_resume() noexcept; | ||
| }; | ||
|
|
||
| template <class R> struct awaiter { | ||
| bool await_ready() noexcept; | ||
| void await_suspend(std::coroutine_handle<>) noexcept; | ||
| R await_resume() noexcept; | ||
| }; | ||
|
|
||
| struct task; | ||
|
|
||
| struct promise { | ||
| suspend initial_suspend() noexcept; | ||
| suspend final_suspend() noexcept; | ||
| void return_void(); | ||
| void unhandled_exception(); | ||
| task get_return_object(); | ||
| awaiter<int &> yield_value(int); | ||
| }; | ||
|
|
||
| struct task { | ||
| using promise_type = promise; | ||
| }; | ||
|
|
||
| task f() { | ||
| (co_await awaiter<bool &>{}) = false; | ||
| bool *p = &co_await awaiter<bool &>{}; | ||
| decltype(auto) a = co_await awaiter<bool &>{}; | ||
| decltype(auto) b = co_await awaiter<bool &&>{}; | ||
| decltype(auto) c = co_await awaiter<bool>{}; | ||
| static_assert(std::is_same<decltype(a), bool &>::value); | ||
| static_assert(std::is_same<decltype(b), bool &&>::value); | ||
| static_assert(std::is_same<decltype(c), bool>::value); | ||
| int &r = co_yield 1; | ||
| decltype(auto) d = co_yield 1; | ||
| static_assert(std::is_same<decltype(d), int &>::value); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,8 @@ | ||
| cpfe -DTEST_NUMBER=1 --set_flag coroutines --no_ms_perm --microsoft_v 1923 Test_name.c | ||
| "Test_name.c", line 51: error: initial value of reference to non-const must be an lvalue | ||
| Immovable &r1 = co_await Aw{}; | ||
| ^ | ||
|
|
||
| 1 error detected in the compilation of "Test_name.c". | ||
| eccp: diagnostics generated from compilation of Test_name.int.c: | ||
| Test_name.c: In function '_Z1fv': | ||
| Test_name.c:51:14: error: 'co_await__T9' undeclared (first use in this function) | ||
| Test_name.c:51:14: note: each undeclared identifier is reported only once for each function it appears in | ||
| Test_name.c:51:172: error: '__T18' undeclared (first use in this function); did you mean '__T17'? | ||
| eccp: end of diagnostics from compilation of Test_name.int.c | ||
| eccp: gcc compilation of Test_name.int.c returned an exit status of 1 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making
await_readyandawait_resumeboth constexpr will get us an internal error:internal error: assertion failed at: "lower_il.c", line 14853 in lower_reuse_value_exprSeems like there are more fixes needed in that area.