fix/Handle cross-year dedupes with deletes in student academic records#180
Open
fix/Handle cross-year dedupes with deletes in student academic records#180
Conversation
sleblanc23
approved these changes
Mar 13, 2026
Contributor
sleblanc23
left a comment
sleblanc23
left a comment
There was a problem hiding this comment.
This looks good to me Alex! It got me wondering whether there are other places we might want to apply this logic. I could see a previous year's data being accidentally pushed then deleted. I tried searching for places where we were ordering by api_year, which I think should tell us where this might be needed:
- calendars
- course_transcripts
- education_organization_network_associations
- staff_education_organization_assignment_associations
- staff_education_organization_employment_associations
This could totally be a separate chunk of work, so not a blocker to merging this PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have comparable logic on other resources introduced in #123; believe we also need to handle this for student academic records as well. Seeing cases in SC where deletes in later ODSes are overriding undeleted records in previous ODSes.