Using flatbuffer rules from baselibs#173
Open
MaciejKaszynski wants to merge 5 commits into
Open
Conversation
MaciejKaszynski
had a problem deploying
to
workflow-approval
GitHub Actions
Failure
MaciejKaszynski
had a problem deploying
to
workflow-approval
GitHub Actions
Failure
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
MaciejKaszynski
force-pushed
the
use-fbs-rules
branch
from
70c9b2a to
8fb86d5
Compare
MaciejKaszynski
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
MaciejKaszynski
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
MaciejKaszynski
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
MaciejKaszynski
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
MaciejKaszynski
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
MaciejKaszynski
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
MaciejKaszynski
force-pushed
the
use-fbs-rules
branch
from
8097b6e to
0c1f669
Compare
MaciejKaszynski
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
MaciejKaszynski
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
| "//score/launch_manager/daemon/src/alive_monitor/details/timers:timers_os_clock", | ||
| "//score/launch_manager/daemon/src/alive_monitor/details/watchdog:i_device_config_factory", | ||
| "@flatbuffers", | ||
| "@score_baselibs//score/flatbuffers:flatbufferscpp", |
Contributor
There was a problem hiding this comment.
Should this dependency be directly on the config target instead of here?
| "//score/launch_manager/daemon/src/alive_monitor/details/timers:timers_os_clock", | ||
| "//score/launch_manager/daemon/src/common:identifier_hash", | ||
| "@flatbuffers", | ||
| "@score_baselibs//score/flatbuffers:flatbufferscpp", |
Contributor
There was a problem hiding this comment.
Should this dependency be directly on the config target instead of here?
| srcs = [ | ||
| "launch_manager.schema.json", | ||
| ], | ||
| visibility = ["//visibility:public"], |
Contributor
There was a problem hiding this comment.
Do we need both filegroup with public visibility and export_files?
| @@ -0,0 +1,90 @@ | |||
| namespace LMFlatBuffer; | |||
Contributor
There was a problem hiding this comment.
Is this file only moved? It appears as new file and no other file removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #154