refactor: centralize Bazel path handling for docs builds - #834
Draft
AlexanderLanin wants to merge 1 commit into
Draft
AlexanderLanin wants to merge 1 commit into
AlexanderLanin wants to merge 1 commit into
Conversation
Contributor
|
Documentation preview for this pull request is available at: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Make path handling consistent across direct invocation, bazel run, and sandboxed Needs builds. Inputs currently arrive as cwd-relative paths, runfiles keys, or execroot paths; handling those differences at each caller makes the extensions and CLI harder to reason about and brittle for generated or external files. Centralizing execution-mode resolution and making each Bazel path contract explicit reduces duplicated logic while keeping sandbox actions hermetic.
What changed
The TEMPORARY DIFF NOTE comments in the Starlark files are intentionally included in this draft to make the broad migration easier to review; they can be removed before marking the PR ready.