refactor: remove sphinxdocs dependency - #812
Merged
AlexanderLanin merged 3 commits intoSep 9, 2026
Merged
Conversation
Contributor
|
Documentation preview for this pull request is available at: |
AlexanderLanin
force-pushed
the
backup/full-sphinx-replacement
branch
from
September 9, 2026 13:36
792b8fa to
ceabea7
Compare
MaximilianSoerenPollak
left a comment
MaximilianSoerenPollak
left a comment
Contributor
There was a problem hiding this comment.
Sone questions for sure, but the premise looks nice.
AlexanderLanin
marked this pull request as ready for review
September 9, 2026 14:44
AlexanderLanin
requested review from
a-zw,
dcalavrezo-qorix and
nradakovic
as code owners
September 9, 2026 14:44
There was a problem hiding this comment.
🟢 Approval recommended
The new action preserves declared inputs, output structure, configuration, and existing interactive CLI behavior without identified unresolved issues.
Review details
- Files reviewed: 6/7 changed files
- Comments generated: 0 new
- Review effort level: Balanced
MaximilianSoerenPollak
approved these changes
Sep 9, 2026
MaximilianSoerenPollak
left a comment
MaximilianSoerenPollak
left a comment
Contributor
There was a problem hiding this comment.
Talked about in a call.
Good next step for refactoring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The documentation build still depends on the external
sphinxdocsBazel module for Needs generation, even though the surrounding bundle and CLI behavior is maintained in this repository. Removing that split ownership simplifies the build and keeps the Needs action aligned with the repository-owned bundle provider.What changed
sphinxdocsmodule and lockfile dependency plus obsolete adapter code.