feat: add strict/permissive compiler warning modes and fix warnings#539
Draft
AAmbuj wants to merge 1 commit into
Draft
feat: add strict/permissive compiler warning modes and fix warnings#539AAmbuj wants to merge 1 commit into
AAmbuj wants to merge 1 commit into
Conversation
AAmbuj
commented
Jun 13, 2026
AAmbuj
commented
Contributor
- Add cc_feature definitions for GCC and Clang warning profiles
- Configure --config=strict (warnings as errors) and --config=permissive
- Move Clang-specific shadow flags to toolchain-conditional BUILD
- Fix unused variables, unused captures, and shadow warnings in source
- Add cc_feature definitions for GCC and Clang warning profiles - Configure --config=strict (warnings as errors) and --config=permissive - Move Clang-specific shadow flags to toolchain-conditional BUILD - Fix unused variables, unused captures, and shadow warnings in source
AAmbuj
force-pushed
the
amsh_fix_compiler_warning_features
branch
from
ed18b26 to
7a20da5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.