Skip to content

fix(seccomp): allow pread64 in VMM thread for Aarch64#20

Merged
bchalios merged 1 commit into
firecracker-v1.14-direct-memfrom
fix/aarch64-seccomp-filter
Jun 17, 2026
Merged

fix(seccomp): allow pread64 in VMM thread for Aarch64#20
bchalios merged 1 commit into
firecracker-v1.14-direct-memfrom
fix/aarch64-seccomp-filter

Conversation

@bchalios

Copy link
Copy Markdown
Collaborator

Commit 92eacbd allow-listed calling pread64 from the VMM thread, so that we can read which pages are dirty from the pagemap. But it only did it for x86 architecture.

Allow it also on Aarch64.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkbuild --all to verify that the PR passes
    build checks on all supported architectures.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • I have mentioned all user-facing changes in CHANGELOG.md.
  • If a specific issue led to this PR, this PR closes the issue.
  • When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • I have linked an issue to every new TODO.

  • This functionality cannot be added in rust-vmm.

@cla-bot cla-bot Bot added the cla-signed label Jun 17, 2026
@cursor

cursor Bot commented Jun 17, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Single syscall allow-list entry in the VMM filter; aligns AArch64 with an existing x86_64 exception and does not broaden API or vCPU filters.

Overview
Adds pread64 to the VMM seccomp allow-list in resources/seccomp/aarch64-unknown-linux-musl.json, with the same rationale as on x86: pagemap reads for dirty-memory tracking during snapshot/diff flows.

This closes an architecture gap where the VMM thread could trap on pread64 on AArch64 builds even though the syscall was already permitted for x86_64.

Reviewed by Cursor Bugbot for commit a9b0123. Bugbot is set up for automated code reviews on this repo. Configure here.

Comment thread resources/seccomp/aarch64-unknown-linux-musl.json Outdated
Commit 92eacbd allow-listed calling
pread64 from the VMM thread, so that we can read which pages are dirty
from the pagemap. But it only did it for x86 architecture.

Allow it also on Aarch64.

Signed-off-by: Babis Chalios <babis.chalios@e2b.dev>
@bchalios bchalios force-pushed the fix/aarch64-seccomp-filter branch from 856a5df to a9b0123 Compare June 17, 2026 12:07
@bchalios bchalios merged commit 6c3e588 into firecracker-v1.14-direct-mem Jun 17, 2026
4 checks passed
@bchalios bchalios deleted the fix/aarch64-seccomp-filter branch June 17, 2026 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants