Improve SolidStart benchmark link rendering - #384
Conversation
|
@brenelz So, I 100% agree that using a native For example, when I use TanStack, I use their native link component and only use an Let me know what you think. I know this makes it hard, as some don't, i.e Astro and Svelte compile, but this is laid out in the methodology. We could work on making this clearer |
|
So I can understand that viewpoint. I think using lowercase anchors are actually the recommended way in Solid these days. We do event delegation so the client side navigation still works. You actually dont lose functionality using lowercase a as far as I know |
|
I will take this to the E18E core team to have a chat about it. We can drop down to the
|
|
approving because the change seems sane but don't merge yet as i agree we need to discuss 👍 |
|
So one of the examples in the SolidStart docs was updated to replace Leaning towards merging this now rather than later, but two things:
|
|
Solid is updating thier docs to reflect this: solidjs/solid-docs#1620 |
Summary
Local results
Local timing output is intentionally excluded from the commit so Depot CI can generate comparable canonical stats.
Verification
Checklist