fix(proxy): only route GET to dfdaemon, bypass other methods#1773
Open
Looka149 wants to merge 2 commits intodragonflyoss:mainfrom
Open
fix(proxy): only route GET to dfdaemon, bypass other methods#1773Looka149 wants to merge 2 commits intodragonflyoss:mainfrom
Looka149 wants to merge 2 commits intodragonflyoss:mainfrom
Conversation
Looka149
requested review from
LunaWhispers,
fcgxz2003,
hhhhsdxxxx,
imeoer,
jim3ma and
mingcheng
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1773 +/- ##
==========================================
- Coverage 44.53% 44.41% -0.13%
==========================================
Files 91 91
Lines 25790 26054 +264
==========================================
+ Hits 11485 11571 +86
- Misses 14305 14483 +178
🚀 New features to boost your workflow:
|
Member
|
@Looka149 There is no need to route HEAD requests via the P2P network. |
Looka149
force-pushed
the
fix/proxy-method-filter
branch
from
a6a6ed1 to
5a91c0d
Compare
Looka149
force-pushed
the
fix/proxy-method-filter
branch
from
5a91c0d to
2ba50a2
Compare
Author
|
@gaius-qi |
Looka149
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Only route GET requests to
proxy_via_dfdaemon(). Other methods fall through to direct proxy.Related Issue
#1772
Motivation and Context
Screenshots (if appropriate)