[release/10.0] Fix ZIP64 header corruption when large file at large offset#124468
Open
github-actions[bot] wants to merge 4 commits intorelease/10.0from
Open
[release/10.0] Fix ZIP64 header corruption when large file at large offset#124468github-actions[bot] wants to merge 4 commits intorelease/10.0from
github-actions[bot] wants to merge 4 commits intorelease/10.0from
Conversation
When both AreSizesTooLarge and IsOffsetTooLarge are true, the Zip64ExtraField was being overwritten in the central directory header logic, losing the size information. This fixes the issue by reusing the existing Zip64ExtraField when adding the offset, using ??= instead of creating a new object. Fixes #114205 Co-authored-by: stephentoub <2642209+stephentoub@users.noreply.github.com>
Wrap buffer allocation in try-catch for OutOfMemoryException and throw SkipTestException to gracefully skip the test when insufficient memory is available. Co-authored-by: stephentoub <2642209+stephentoub@users.noreply.github.com>
Contributor
|
Tagging subscribers to this area: @karelz, @dotnet/area-system-io-compression |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #122837 to release/10.0
/cc @iremyux @copilot
Customer Impact
[Select one or both of the boxes. Describe how this issue impacts customers, citing the expected and actual behaviors and scope of the issue. If customer-reported, provide the issue number.]
Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
Testing
[How was the fix verified? How was the issue missed previously? What tests were added?]
Risk
[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]
IMPORTANT: If this backport is for a servicing release, please verify that:
release/X.0-staging, notrelease/X.0.release/X.0(no-stagingsuffix).Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.