Skip to content

Re-enable SslStreamTlsResumeTests.ClientDisableTlsResume_Succeeds#124463

Merged
rzikm merged 2 commits intomainfrom
copilot/fix-sslstream-tls-resume-test
Feb 17, 2026
Merged

Re-enable SslStreamTlsResumeTests.ClientDisableTlsResume_Succeeds#124463
rzikm merged 2 commits intomainfrom
copilot/fix-sslstream-tls-resume-test

Conversation

Copy link
Contributor

Copilot AI commented Feb 16, 2026 •
edited
Loading

Description

Test ClientDisableTlsResume_Succeeds was disabled on Windows due to flaky TLS session resumption behavior. Issue comments indicate the underlying SChannel bug was fixed in PR #113604, but the test remained disabled. Re-enabling to verify resolution in CI.

Changes

  • Remove [ActiveIssue] attribute from ClientDisableTlsResume_Succeeds test method

Test validates that setting AllowTlsResume = false properly prevents TLS session resumption. Previously failed intermittently on Windows with sessions resuming when they shouldn't.

Test Results

Both parameterized test cases pass on Linux:

  • ClientDisableTlsResume_Succeeds(testClient: True)
  • ClientDisableTlsResume_Succeeds(testClient: False)

CI will validate Windows behavior.

Original prompt

This section details on the original issue you should resolve

<issue_title>SslStreamTlsResumeTests.ClientDisableTlsResume_Succeeds failed in CI</issue_title>
<issue_description>## Build Information
Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=707064
Build error leg or test failing: System.Net.Security.Tests.SslStreamTlsResumeTests.ClientDisableTlsResume_Succeeds
Pull request: #103309

Error Message

Fill the error message using step by step known issues guidance.

{
  "ErrorMessage": "ClientDisableTlsResume_Succeeds",
  "ErrorPattern": "",
  "BuildRetry": false,
  "ExcludeConsoleLog": false
}
❌ System.Net.Security.Tests.SslStreamTlsResumeTests.ClientDisableTlsResume_Succeeds(testClient: True)
Exception Message
TLS session resumed in round $2
Stack Trace
   at System.Net.Security.Tests.SslStreamTlsResumeTests.ClientDisableTlsResume_Succeeds(Boolean testClient) in /_/src/libraries/System.Net.Security/tests/FunctionalTests/SslStreamAllowTlsResumeTests.cs:line 99
--- End of stack trace from previous location ---

Known issue validation

Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=707064
Error message validated: [ClientDisableTlsResume_Succeeds]
Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 6/14/2024 11:26:27 PM UTC

Report

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
0 0 0

<agent_instructions>Raise a PR which reenables the test to see if the issue persists</agent_instructions>

Comments on the Issue (you are @copilot in this section)

@stephentoub @rzikm, can we disable this test? It's failing a lot. @rzikm The behavior seems to be flaky and seems to depend on timing, the bug has been passed to SChannel team for investigation. @rzikm Removing from 9.0.0, as this is not critical for 9.0 and the SChannel team is currently busy with higher priority investigations. @jeffschwMSFT removing blocking-clean-ci as it has not failed in 30 days
24-Hour Hit Count 7-Day Hit Count 1-Month Count
0 0 0
@jkotas This failed again in #113416 windows-Debug-x64-coreclr_release-Windows.Amd64.Server2022.Open.

From https://helixr1107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-113416-merge-2f216bd0c68a49be87/System.Net.Security.Tests/3/console.734dc56a.log?helixlogtype=result:

    System.Net.Security.Tests.SslStreamTlsResumeTests.ClientDisableTlsResume_Succeeds(testClient: True) [FAIL]
      TLS session resumed in round $2
      Stack Trace:
        /_/src/libraries/System.Net.Security/tests/FunctionalTests/SslStreamAllowTlsResumeTests.cs(99,0): at System.Net.Security.Tests.SslStreamTlsResumeTests.ClientDisableTlsResume_Succeeds(Boolean testClient)
        --- End of stack trace from previous location ---
```</body></comment_new>
<comment_new><author>@ManickaP</author><body>
Fixed by https://github.com/dotnet/runtime/pull/113604</body></comment_new>
<comment_new><author>@liveans</author><body>
> Fixed by [#113604](https://github.com/dotnet/runtime/pull/113604)

This test is still disabled
https://github.com/dotnet/runtime/blob/3057101c0479ff67b389d5a578b3e25cc8b8512a/src/libraries/System.Net.Security/tests/FunctionalTests/SslStreamAllowTlsResumeTests.cs#L37-L38</body></comment_new>
</comments>

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Feb 16, 2026
@rzikm
Re-enable SslStreamTlsResumeTests.ClientDisableTlsResume_Succeeds test
051bb61 
Co-authored-by: rzikm <32671551+rzikm@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix SslStreamTlsResumeTests.ClientDisableTlsResume_Succeeds CI failure Re-enable SslStreamTlsResumeTests.ClientDisableTlsResume_Succeeds Feb 16, 2026
Copilot AI requested a review from rzikm February 16, 2026 12:41
@rzikm rzikm marked this pull request as ready for review February 16, 2026 17:14
@rzikm rzikm requested review from a team and Copilot February 16, 2026 17:14
@rzikm rzikm added area-System.Net.Security and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Feb 16, 2026
@rzikm
Copy link
Member

rzikm commented Feb 16, 2026

I can't reproduce the issue locally, I will see if it reproduces overnight, otherwise, I think we can merge this

@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Feb 16, 2026

Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

Copilot AI reviewed Feb 16, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Re-enables the SslStreamTlsResumeTests.ClientDisableTlsResume_Succeeds functional test in System.Net.Security by removing the Windows-specific [ActiveIssue] skip, based on indications that the underlying SChannel/session resumption flakiness has been addressed.

Changes:

  • Remove the [ActiveIssue("https://github.com/dotnet/runtime/issues/103449", TestPlatforms.Windows)] attribute from ClientDisableTlsResume_Succeeds.

wfurt
wfurt approved these changes Feb 16, 2026
View reviewed changes
Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can try it. It may be timing problem and/or it may behave different way on different windows versions.

@rzikm
Copy link
Member

rzikm commented Feb 17, 2026

/ba-g test failures are not related

@rzikm
Copy link
Member

rzikm commented Feb 17, 2026

The issue did not reproduce locally when run in a loop overnight (it used to in the past), so we can merge this.

@rzikm rzikm merged commit 1c7b5c4 into main Feb 17, 2026
94 of 98 checks passed
@dotnet-maestro dotnet-maestro bot mentioned this pull request Feb 18, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@wfurt wfurt wfurt approved these changes

@rzikm rzikm Awaiting requested review from rzikm

Assignees

@rzikm rzikm

Copilot code review Copilot

Labels

area-System.Net.Security

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SslStreamTlsResumeTests.ClientDisableTlsResume_Succeeds failed in CI

3 participants

@rzikm @wfurt