Conversation
Now that we have DOTNET_MODIFIABLE_ASSEMBLIES as a supported config option we shouldn't also need DOTNET_ForceEnc env var Addresses part of dotnet#124017
Contributor
|
Tagging subscribers to this area: @agocke |
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the legacy/undocumented ForceEnc (aka ForceEnc config / env var) switch from CoreCLR configuration and EnC enablement paths, relying on the supported DOTNET_MODIFIABLE_ASSEMBLIES mechanism instead (per #124017).
Changes:
- Removed
EEConfig::ForceEnc()and the backingfForceEncfield and initialization. - Removed reading of
UNSUPPORTED_ForceEncfrom configuration. - Updated EnC/apply-update gating to no longer consider
ForceEnc.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/coreclr/vm/eeconfig.h | Removes ForceEnc() accessor and fForceEnc field from EEConfig. |
| src/coreclr/vm/eeconfig.cpp | Removes fForceEnc initialization and config sync read of UNSUPPORTED_ForceEnc. |
| src/coreclr/vm/ceeload.cpp | Stops using g_pConfig->ForceEnc() when deciding whether to enable EnC for a module. |
| src/coreclr/vm/assemblynative.cpp | Stops using g_pConfig->ForceEnc() for AssemblyNative_IsApplyUpdateSupported(). |
| src/coreclr/inc/clrconfigvalues.h | Removes the UNSUPPORTED_ForceEnc config value definition. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we have DOTNET_MODIFIABLE_ASSEMBLIES as a supported config option we shouldn't also need DOTNET_ForceEnc env var Addresses part of #124017
@barosiak - I happened to be testing some stuff out with copilot and this seemed like a simple one to point it at. We still shouldn't resolve 124017 until the VS part is handled too.