Document ten AppKit enum types - #26535
Open
rolfbjarne wants to merge 11 commits into
Open
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9a37ff16-2fda-4715-8343-f3408ac8c442
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9a37ff16-2fda-4715-8343-f3408ac8c442
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9a37ff16-2fda-4715-8343-f3408ac8c442
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9a37ff16-2fda-4715-8343-f3408ac8c442
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9a37ff16-2fda-4715-8343-f3408ac8c442
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9a37ff16-2fda-4715-8343-f3408ac8c442
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9a37ff16-2fda-4715-8343-f3408ac8c442
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9a37ff16-2fda-4715-8343-f3408ac8c442
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9a37ff16-2fda-4715-8343-f3408ac8c442
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9a37ff16-2fda-4715-8343-f3408ac8c442
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes are documentation-only and the known-failures baseline updates align with the documented enums, with only a minor documentation wording suggestion noted.
Pull request overview
This PR improves API documentation quality for AppKit by replacing placeholder XML documentation with complete summaries for ten enum types (and their members) in src/AppKit/Enums.cs, and then removing the corresponding Cecil documentation known-failure entries so the doc tests reflect the new coverage.
Changes:
- Added XML
<summary>documentation for ten AppKit enum types and their values (replacing “To be added.” placeholders). - Removed the now-resolved type entries from
tests/cecil-tests/Documentation.KnownFailures.txtto keep the documentation baseline up to date.
File summaries
| File | Description |
|---|---|
| tests/cecil-tests/Documentation.KnownFailures.txt | Removes known-failure entries for the enum types now fully documented. |
| src/AppKit/Enums.cs | Adds/updates XML documentation for the specified AppKit enums and their members. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9a37ff16-2fda-4715-8343-f3408ac8c442
rolfbjarne
enabled auto-merge (squash)
September 2, 2026 11:43
This comment has been minimized.
This comment has been minimized.
Collaborator
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
This was referenced Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add complete XML documentation for ten AppKit enum types and their members:
NSAccessibilityAnnotationPositionNSAccessibilityCustomRotorSearchDirectionNSAnimationEffectNSBorderTypeNSBrowserDropOperationNSCollectionElementCategoryNSCollectionUpdateActionNSCellTypeNSCollectionViewScrollDirectionNSColorTypeRemove the corresponding entries from the Cecil documentation known-failures baseline.
🤖 Pull request created by Copilot