Skip to content

[msbuild] Bump Messaging to get updated dependencies. - #26501

Open
rolfbjarne wants to merge 3 commits into
mainfrom
dev/rolf/bump-messaging-2026-08-31
Open

[msbuild] Bump Messaging to get updated dependencies.#26501
rolfbjarne wants to merge 3 commits into
mainfrom
dev/rolf/bump-messaging-2026-08-31

Conversation

@rolfbjarne

@rolfbjarne rolfbjarne commented Aug 31, 2026

Copy link
Copy Markdown
Member

No description provided.

Copilot AI lite review requested due to automatic review settings August 31, 2026 19:12
@rolfbjarne
rolfbjarne requested a review from mauroa as a code owner August 31, 2026 19:12
Copilot AI reviewed Aug 31, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Pull request overview

This PR updates the MSBuild infrastructure’s pinned Xamarin.Messaging package version, ensuring the repo restores a newer Messaging build (and its updated dependencies) while still using exact-version pinning to avoid accidentally selecting test “99.*” packages.

Changes:

  • Bumped the default $(MessagingVersion) used by MSBuild projects to a newer pinned version.
File summaries
File Description
msbuild/Directory.Build.props Updates the default pinned MessagingVersion used for Xamarin.Messaging package references in MSBuild projects.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@rolfbjarne rolfbjarne added the ready-to-review This PR is ready to review/merge. label Sep 2, 2026
@rolfbjarne rolfbjarne mentioned this pull request Sep 2, 2026
Merged
@rolfbjarne
rolfbjarne enabled auto-merge (squash) September 2, 2026 07:14
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
dalexsoto
dalexsoto previously approved these changes Sep 2, 2026
View reviewed changes
rolfbjarne added a commit that referenced this pull request Sep 2, 2026
@rolfbjarne
[xcode27.0] [msbuild] Bump Messaging to get updated dependencies. (#2…
d2024b3 
…6527)

Backport of #26501.
@dalexsoto
[Signing] Sign new Xamarin.Messaging dependencies
dec1c37 
The Xamarin.Messaging 18.11.15 update adds
Microsoft.Extensions.DependencyInjection.Abstractions.dll and
Microsoft.Extensions.Logging.Abstractions.dll to the net10.0 MSBuild tools
in each workload pack.

The signing pipeline rejected these unsigned assemblies because they were not
classified in SignList.xml, causing the Sign Package Contents task to fail in
Azure DevOps build 15183644.

Classify both assemblies as first-party so the iOS, tvOS, macOS, and Mac
Catalyst workload packages include them in package signing.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 589e3158-2c00-4af8-b4d6-a40fe96f20c5
@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

✅ API diff for current PR / commit

NET (empty diffs)

✅ API diff vs stable

NET (empty diffs)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: dec1c3715b473cb49b5be35e1a317c91ee4812ca [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

🚀 [CI Build #dec1c37] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 264 tests passed 🎉

Tests counts

✅ assembly-processing: All 1 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 7 tests passed. Html Report (VSDrops) Download
✅ linker (iOS): All 31 tests passed. Html Report (VSDrops) Download
✅ linker (MacCatalyst): All 31 tests passed. Html Report (VSDrops) Download
✅ linker (macOS): All 21 tests passed. Html Report (VSDrops) Download
✅ linker (tvOS): All 31 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 25 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 25 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 20 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 25 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ sharpie: All 1 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

macOS tests

✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sequoia (15): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Tahoe (26): All 5 tests passed. Html Report (VSDrops) Download

Linux Build Verification

✅ Linux build succeeded

Pipeline on Agent
Hash: dec1c3715b473cb49b5be35e1a317c91ee4812ca [PR build]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@dalexsoto dalexsoto dalexsoto approved these changes
@mauroa mauroa Awaiting requested review from mauroa mauroa is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

ready-to-review This PR is ready to review/merge.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rolfbjarne @vs-mobiletools-engineering-service2 @dalexsoto