Skip to content

Cosmos: Modernize materializer & subdocument projectionbinding#38550

Merged
AndriySvyryd merged 290 commits into
dotnet:mainfrom
JoasE:feature/#34567-Materialization
Jul 15, 2026
Merged

Cosmos: Modernize materializer & subdocument projectionbinding#38550
AndriySvyryd merged 290 commits into
dotnet:mainfrom
JoasE:feature/#34567-Materialization

Conversation

@JoasE

@JoasE JoasE commented Jul 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Part of: #34567
Implements: #34067
Fixes: #38138 , #31696

JoasE added 30 commits April 19, 2026 09:53
@JoasE
Fix inheritance
d524374
@JoasE
WIP
4e4fa83
@JoasE
WIP
f91a45c
@JoasE
WIP
654ae55
@JoasE
WIP
c9e0b86
@JoasE
WIP
611d8a6
@JoasE
WIP
0c6a507
@JoasE
WIP
fecd0d0
@JoasE
WIP
fd1adb8
@JoasE
Revert changes
5ab9c5e
@JoasE
WIP: Working non collections
99dc183
@JoasE
Fix nested collection
fe499e6
@JoasE
WIP: CollectionShaper?
1fd10b8
@JoasE
Fix owned mappings
5747ad1
@JoasE
Select method
9c4de60
@JoasE
Select_nested_collection_on_optional_associate
865a911
@JoasE
ShapedQueryCompilingExpressionVisitor fix?
4bc3bcc
@JoasE
Fix tracking variable
04a1dba
@JoasE
Fix ownerMappings
b3960d7
@JoasE
Fix entityEntry
d2adfb0
@JoasE
Merge branch 'feature/dotnet#34067-ProjectSubDocuments' into feature/d…
a0802db 
…otnet#34567-Materialization
@JoasE
Fix merge conflicts
aa3b472
@JoasE
WIP subquery
fe18c49
@JoasE
nested collection
46bed52
@JoasE
AssertTranslationFailed
7c91ced
@JoasE
Distinct associate
c60455a
@JoasE
Owned tests cleanup
eed0efe
@JoasE
Complex and value types
fcab84e
@JoasE
Bind complex collections via CollectionShaperExpression
0426383
@JoasE
Throw for structural subquery projections
29b7ae0
AndriySvyryd
AndriySvyryd reviewed Jul 14, 2026
View reviewed changes
Comment thread src/EFCore.Cosmos/Update/Internal/DocumentSource.cs
@AndriySvyryd
AndriySvyryd requested a review from cincuranet July 14, 2026 05:17
Copilot AI review requested due to automatic review settings July 15, 2026 16:06
Copilot AI reviewed Jul 15, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 100 out of 104 changed files in this pull request and generated 2 comments.

Files not reviewed (1)
  • src/EFCore.Cosmos/Properties/CosmosStrings.Designer.cs: Generated file

Comment thread src/EFCore/Storage/Json/JsonReaderData.cs
Comment thread src/EFCore.Cosmos/Storage/Internal/CosmosNumberProjectionTypeMapping.cs
Copilot AI review requested due to automatic review settings July 15, 2026 16:19
Copilot AI reviewed Jul 15, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 100 out of 104 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • src/EFCore.Cosmos/Properties/CosmosStrings.Designer.cs: Generated file

Comment thread src/EFCore.Cosmos/Query/Internal/CosmosQueryableMethodTranslatingExpressionVisitor.cs
Copilot AI review requested due to automatic review settings July 15, 2026 16:57
Copilot AI reviewed Jul 15, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 100 out of 104 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • src/EFCore.Cosmos/Properties/CosmosStrings.Designer.cs: Generated file

Comment thread src/EFCore/Storage/Json/JsonReaderData.cs
@AndriySvyryd AndriySvyryd mentioned this pull request Jul 15, 2026
Closed
Copilot AI review requested due to automatic review settings July 15, 2026 18:28
Copilot AI reviewed Jul 15, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 106 out of 110 changed files in this pull request and generated 2 comments.

Files not reviewed (1)
  • src/EFCore.Cosmos/Properties/CosmosStrings.Designer.cs: Generated file

Comment thread src/EFCore.Cosmos/Storage/Internal/CosmosJsonDecimalReaderWriter.cs
Comment thread test/EFCore.Cosmos.FunctionalTests/Query/OwnedQueryCosmosTest.cs
AndriySvyryd
AndriySvyryd approved these changes Jul 15, 2026
View reviewed changes

@AndriySvyryd AndriySvyryd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@AndriySvyryd
AndriySvyryd merged commit 6d6d3c3 into dotnet:main Jul 15, 2026
15 checks passed
@github-actions github-actions Bot added the api-review This PR or issue is introducing public API changes that need to be reviewed label Jul 15, 2026
@dotnet-maestro dotnet-maestro Bot mentioned this pull request Jul 16, 2026
Merged
@dotnet-milestone-bot dotnet-milestone-bot Bot added this to the 11.0-preview7 milestone Jul 16, 2026
@JoasE
JoasE deleted the feature/#34567-Materialization branch July 17, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@AndriySvyryd AndriySvyryd AndriySvyryd approved these changes
@cincuranet cincuranet Awaiting requested review from cincuranet

Assignees

@AndriySvyryd AndriySvyryd

Labels

api-review This PR or issue is introducing public API changes that need to be reviewed community-contribution

Projects

None yet

Milestone

11.0-preview7

Development

Successfully merging this pull request may close these issues.

Cosmos: Materializer rounds when deserializing floating point numbers as fixed point numbers

3 participants

@JoasE @AndriySvyryd