Skip to content

Replace all occurences of redundant spacing in if condition#54405

Merged
BillWagner merged 1 commit into
dotnet:mainfrom
BartoszKlonowski:54380/fix/conditional-space-typo
Jun 18, 2026
Merged

Replace all occurences of redundant spacing in if condition#54405
BillWagner merged 1 commit into
dotnet:mainfrom
BartoszKlonowski:54380/fix/conditional-space-typo

Conversation

@BartoszKlonowski

@BartoszKlonowski BartoszKlonowski commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

This pull request fixes #54380 along with other cases where the same problem exists.
This commit replaces all (29 in total as per grep results count):
if (! condition)
with
if (!condition)
according to the general formatting in the code base.

From what I saw, this typo happens mostly in old (couple of years even) files, and was there when migrated from samples repository.


Internal previews

📄 File 🔗 Preview link
docs/framework/unmanaged-api/fusion/identity-attribute-blob-structure.md IDENTITY_ATTRIBUTE_BLOB Structure

@BartoszKlonowski BartoszKlonowski requested review from a team and BillWagner as code owners June 15, 2026 22:58
@dotnetrepoman dotnetrepoman Bot added this to the June 2026 milestone Jun 15, 2026
@dotnet-policy-service dotnet-policy-service Bot added the community-contribution Indicates PR is created by someone from the .NET community. label Jun 15, 2026

@BillWagner BillWagner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @BartoszKlonowski

Pending any unexpected CI errors, I'll :shipit:

@BillWagner BillWagner enabled auto-merge (squash) June 16, 2026 15:42
auto-merge was automatically disabled June 16, 2026 17:33

Head branch was pushed to by a user without write access

@BartoszKlonowski

Copy link
Copy Markdown
Contributor Author

@BillWagner I've (naively) added missing cscproj'es, but I saw that there really is couple of main.
What can we do with those?

@adegeo

adegeo commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

The new snippet build system isn't designed for the old snippets. I wouldn't worry about it because you're playing cat-and-mouse trying to fit it in and if you're going to spend time doing that, you should just move them to the new system.

@BartoszKlonowski

Copy link
Copy Markdown
Contributor Author

@adegeo

you should just move them to the new system.

Means we want to migrate them to a single main method, or you have something else in mind?

@adegeo

adegeo commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Sorry @BartoszKlonowski I wasn't implying YOU should move them the new system, I meant that patching them up in the old system to work in fit the style of the new system is a pointless endeavor (generally). So don't worry about it 😁 Bill was saying up above that he knows they'll fail, so when you're done he'll use his admin rights to push the PR through.

@BillWagner

Copy link
Copy Markdown
Member

OK, I fell behind here because of lots of commitments yesterday. Thanks @adegeo for jumping in.

Yes, in this instance, because this is a horizontal change, we'll bypass the check. As we do anything targeted on any of the samples, we'll move them.

One question now: How did the merge conflicts arise? I don't see a related PR that came in the interim.

@adegeo

adegeo commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

I checked on that and I couldn't figure it out. I'm going to pull down the PR and see what's going on at the terminal level.

@adegeo

adegeo commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Ahh OK. #54411 deleted a bunch of files that this PR is touching. This PR is touching files that probably aren't referenced by articles, and can be deleted.

@BartoszKlonowski To fix the PR, I would:

  1. Revert the changes to the csproj file commit to get those out.
  2. Merge in main and delete the files that were deleted.

@BartoszKlonowski

Copy link
Copy Markdown
Contributor Author

@adegeo No worries, I'm on it 🫡

@BartoszKlonowski BartoszKlonowski force-pushed the 54380/fix/conditional-space-typo branch from 077575b to c877b59 Compare June 17, 2026 20:06

@BillWagner BillWagner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve this, and bypass the snippets build to merge it.

@BillWagner BillWagner merged commit 7dd578e into dotnet:main Jun 18, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contribution Indicates PR is created by someone from the .NET community.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extra space typo

3 participants