Replace all occurences of redundant spacing in if condition#54405
Conversation
BillWagner
left a comment
There was a problem hiding this comment.
This LGTM @BartoszKlonowski
Pending any unexpected CI errors, I'll ![]()
Head branch was pushed to by a user without write access
|
@BillWagner I've (naively) added missing cscproj'es, but I saw that there really is couple of |
|
The new snippet build system isn't designed for the old snippets. I wouldn't worry about it because you're playing cat-and-mouse trying to fit it in and if you're going to spend time doing that, you should just move them to the new system. |
Means we want to migrate them to a single |
|
Sorry @BartoszKlonowski I wasn't implying YOU should move them the new system, I meant that patching them up in the old system to work in fit the style of the new system is a pointless endeavor (generally). So don't worry about it 😁 Bill was saying up above that he knows they'll fail, so when you're done he'll use his admin rights to push the PR through. |
|
OK, I fell behind here because of lots of commitments yesterday. Thanks @adegeo for jumping in. Yes, in this instance, because this is a horizontal change, we'll bypass the check. As we do anything targeted on any of the samples, we'll move them. One question now: How did the merge conflicts arise? I don't see a related PR that came in the interim. |
|
I checked on that and I couldn't figure it out. I'm going to pull down the PR and see what's going on at the terminal level. |
|
Ahh OK. #54411 deleted a bunch of files that this PR is touching. This PR is touching files that probably aren't referenced by articles, and can be deleted. @BartoszKlonowski To fix the PR, I would:
|
|
@adegeo No worries, I'm on it 🫡 |
077575b to
c877b59
Compare
BillWagner
left a comment
There was a problem hiding this comment.
I'll approve this, and bypass the snippets build to merge it.
This pull request fixes #54380 along with other cases where the same problem exists.
This commit replaces all (29 in total as per grep results count):
if (! condition)with
if (!condition)according to the general formatting in the code base.
From what I saw, this typo happens mostly in old (couple of years even) files, and was there when migrated from samples repository.
Internal previews