[r8-obfuscation] Add R8 JNI mapping primitives

src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/Utilities/JniRemapping/JniDescriptorTextTests.cs

@@ -0,0 +1,100 @@
+using System;
+using NUnit.Framework;
+using Xamarin.Android.Tasks.JniRemapping;
+
+namespace Xamarin.Android.Build.Tests
+{
+	[TestFixture]
+	[Parallelizable (ParallelScope.Children)]
+	public class JniDescriptorTextTests : BaseTest
+	{
+		static string? Rename (string cls) => cls == "acme/orig/MyView" ? "a/b/C" : null;
+
+		[Test]
+		public void RewritesObjectParameterAndReturnTypes ()
+		{
+			bool changed = JniDescriptorText.TryRewriteDescriptor ("(Lacme/orig/MyView;I)Lacme/orig/MyView;", Rename, out string rewritten);
+
+			Assert.IsTrue (changed);
+			Assert.AreEqual ("(La/b/C;I)La/b/C;", rewritten);
+		}
+
+		[Test]
+		public void RewritesArrayOfObjectType ()
+		{
+			bool changed = JniDescriptorText.TryRewriteDescriptor ("[Lacme/orig/MyView;", Rename, out string rewritten);
+
+			Assert.IsTrue (changed);
+			Assert.AreEqual ("[La/b/C;", rewritten);
+		}
+
+		[Test]
+		public void LeavesUnrelatedTypesAndPrimitivesAlone ()
+		{
+			bool changed = JniDescriptorText.TryRewriteDescriptor ("(Landroid/view/View;[I)V", Rename, out string rewritten);
+
+			Assert.IsFalse (changed);
+			Assert.AreEqual ("(Landroid/view/View;[I)V", rewritten);
+		}
+
+		[TestCase ("()V", true)]
+		[TestCase ("(Ljava/lang/Object;)Z", true)]
+		[TestCase ("(I)I", true)]
+		[TestCase ("(V)V", false)]
+		[TestCase ("()[V", false)]
+		[TestCase ("(L;)V", false)]
+		[TestCase ("(Ljava.lang.Object;)V", false)]
+		[TestCase ("(Lfoo[Bar;)V", false)]
+		[TestCase ("(Lfoo//Bar;)V", false)]
+		[TestCase ("I", false)]
+		[TestCase ("Ljava/lang/Object;", false)]
+		[TestCase ("not a descriptor", false)]
+		public void ValidatesMethodDescriptors (string descriptor, bool expected)
+		{
+			Assert.AreEqual (expected, JniDescriptorText.IsValidMethodDescriptor (descriptor));
+		}
+
+		[TestCase ("I", true)]
+		[TestCase ("[I", true)]
+		[TestCase ("Ljava/lang/Object;", true)]
+		[TestCase ("V", false)]
+		[TestCase ("[V", false)]
+		[TestCase ("L;", false)]
+		[TestCase ("[L;", false)]
+		[TestCase ("Ljava.lang.Object;", false)]
+		[TestCase ("Lfoo[Bar;", false)]
+		[TestCase ("Lfoo//Bar;", false)]
+		[TestCase ("()V", false)]
+		[TestCase ("", false)]
+		public void ValidatesFieldDescriptors (string descriptor, bool expected)
+		{
+			Assert.AreEqual (expected, JniDescriptorText.IsValidFieldDescriptor (descriptor));
+		}
+
+		[Test]
+		public void ConvertsMethodDescriptorToJavaParameterTypes ()
+		{
+			var parameters = JniDescriptorText.MethodDescriptorToJavaParameterTypes ("(Landroid/os/Bundle;I[Ljava/lang/String;)V");
+
+			CollectionAssert.AreEqual (new [] { "android.os.Bundle", "int", "java.lang.String[]" }, parameters);
+		}
+
+		[Test]
+		public void ConvertsSingleTypeTokenToJavaSource ()
+		{
+			Assert.AreEqual ("boolean", JniDescriptorText.JniTypeTokenToJavaSource ("Z"));
+			Assert.AreEqual ("int[]", JniDescriptorText.JniTypeTokenToJavaSource ("[I"));
+			Assert.AreEqual ("java.lang.Object", JniDescriptorText.JniTypeTokenToJavaSource ("Ljava/lang/Object;"));
+		}
+
+		[TestCase ("")]
+		[TestCase ("[")]
+		[TestCase ("L;")]
+		[TestCase ("Ljava.lang.Object;")]
+		[TestCase ("Lfoo[Bar;")]
+		public void RejectsMalformedSingleTypeToken (string token)
+		{
+			Assert.Throws<ArgumentException> (() => JniDescriptorText.JniTypeTokenToJavaSource (token));
+		}
+	}
+}

src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/Utilities/JniRemapping/LdstrRewriterTests.cs

@@ -0,0 +1,122 @@
+using System.IO;
+using NUnit.Framework;
+using Xamarin.Android.Tasks.JniRemapping;
+
+namespace Xamarin.Android.Build.Tests
+{
+	[TestFixture]
+	[Parallelizable (ParallelScope.Children)]
+	public class LdstrRewriterTests : BaseTest
+	{
+		static R8Mapping BuildMapping () => R8Mapping.Parse (new StringReader (
+			"acme.orig.MyView -> a.b.C:\n" +
+			"    void onClick(android.view.View) -> a\n" +
+			"    int someField -> x\n" +
+			"acme.orig.Marker -> a.b.D:\n"));
+
+		[Test]
+		public void RewritesJniPeerMembersEncodedMethodId ()
+		{
+			bool changed = LdstrRewriter.TryRewrite ("onClick.(Landroid/view/View;)V", "acme/orig/MyView", BuildMapping (), out string rewritten);
+
+			Assert.IsTrue (changed);
+			Assert.AreEqual ("a.(Landroid/view/View;)V", rewritten);
+		}
+
+		[Test]
+		public void RewritesJniPeerMembersEncodedFieldId ()
+		{
+			bool changed = LdstrRewriter.TryRewrite ("someField.I", "acme/orig/MyView", BuildMapping (), out string rewritten);
+
+			Assert.IsTrue (changed);
+			Assert.AreEqual ("x.I", rewritten);
+		}
+
+		[Test]
+		public void RewrittenFieldIdRoundTripsThroughAccessManifest ()
+		{
+			R8Mapping mapping = BuildMapping ();
+			Assert.IsTrue (LdstrRewriter.TryRewrite ("someField.I", "acme/orig/MyView", mapping, out string rewritten));
+			mapping.RestrictReverseLookupsTo (mapping.AccessedEntries);
+			IJniNameMapping reverse = mapping.CreateReverseMapping ();
+
+			Assert.AreEqual ("x.I", rewritten);
+			Assert.IsTrue (reverse.TryMapField ("a/b/C", "x", out string originalField));
+			Assert.AreEqual ("someField", originalField);
+		}
+
+		[Test]
+		public void RewritesBareConstructorDescriptorEmbeddedTypesOnly ()
+		{
+			bool changed = LdstrRewriter.TryRewrite ("(Lacme/orig/Marker;)V", "acme/orig/MyView", BuildMapping (), out string rewritten);
+
+			Assert.IsTrue (changed);
+			Assert.AreEqual ("(La/b/D;)V", rewritten);
+		}
+
+		[Test]
+		public void UnchangedBareDescriptorIsReportedAsNotChanged ()
+		{
+			bool changed = LdstrRewriter.TryRewrite ("()V", "acme/orig/MyView", BuildMapping (), out string rewritten);
+
+			Assert.IsFalse (changed);
+			Assert.AreEqual ("()V", rewritten);
+		}
+
+		[Test]
+		public void RewritesSingleRegisterNativesLine ()
+		{
+			bool changed = LdstrRewriter.TryRewrite ("onClick:(Landroid/view/View;)V:cb", "acme/orig/MyView", BuildMapping (), out string rewritten);
+
+			Assert.IsTrue (changed);
+			Assert.AreEqual ("a:(Landroid/view/View;)V:cb", rewritten);
+		}
+
+		[Test]
+		public void RewritesMultilineRegisterNativesBlockWithoutTrailingNewline ()
+		{
+			string original = "onClick:(Landroid/view/View;)V:cb1\nunrelated:()V:cb2";
+			bool changed = LdstrRewriter.TryRewrite (original, "acme/orig/MyView", BuildMapping (), out string rewritten);
+
+			Assert.IsTrue (changed);
+			Assert.AreEqual ("a:(Landroid/view/View;)V:cb1\nunrelated:()V:cb2", rewritten);
+		}
+
+		[Test]
+		public void RewritesMultilineRegisterNativesBlockWithTrailingNewline ()
+		{
+			string original = "onClick:(Landroid/view/View;)V:cb1\n";
+			bool changed = LdstrRewriter.TryRewrite (original, "acme/orig/MyView", BuildMapping (), out string rewritten);
+
+			Assert.IsTrue (changed);
+			Assert.AreEqual ("a:(Landroid/view/View;)V:cb1\n", rewritten);
+		}
+
+		[Test]
+		public void RewritesExactClassNameString ()
+		{
+			bool changed = LdstrRewriter.TryRewrite ("acme/orig/Marker", null, BuildMapping (), out string rewritten);
+
+			Assert.IsTrue (changed);
+			Assert.AreEqual ("a/b/D", rewritten);
+		}
+
+		[Test]
+		public void LeavesUnrelatedDotNetStringsAlone ()
+		{
+			bool changed = LdstrRewriter.TryRewrite ("System.String", "acme/orig/MyView", BuildMapping (), out string rewritten);
+
+			Assert.IsFalse (changed);
+			Assert.AreEqual ("System.String", rewritten);
+		}
+
+		[Test]
+		public void LeavesUnknownMemberIdAloneWhenOwnerUnknown ()
+		{
+			bool changed = LdstrRewriter.TryRewrite ("someField.I", null, BuildMapping (), out string rewritten);
+
+			Assert.IsFalse (changed);
+			Assert.AreEqual ("someField.I", rewritten);
+		}
+	}
+}