Skip to content

Fix reference file logging to avoid logcat output #12620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
simonrozsival wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix reference file logging to avoid logcat output #12620

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/native/clr/host/os-bridge.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,9 @@ void OSBridge::_monodroid_gref_logf (const char *format, ...) noexcept
[[gnu::always_inline, gnu::flatten]]
void OSBridge::log_it (LogCategories category, std::string_view const& line, FILE *to, const char *const from, bool logcat_enabled) noexcept
{
log_writef (category, LogLevel::Info, "%.*s", static_cast<int>(line.length ()), line.data ());
if (to == nullptr || logcat_enabled) {

@github-actions github-actions Bot Sep 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 💡 Testing — This predicate is now the contract separating compact (gref-/lref-), file-only, and file-plus-logcat modes, but the regression is covered only by manual validation. Please consider adding a focused test that exercises the routing combinations—especially to != nullptr && !logcat_enabled alongside the + case—so a future refactor cannot silently restore the logcat flood or suppress explicitly requested output.

Rule: Regression coverage

log_writef (category, LogLevel::Info, "%.*s", static_cast<int>(line.length ()), line.data ());
}

// We skip logcat here when logging to file is enabled because _write_stack_trace will output to logcat as well, if enabled
Comment thread
jonathanpeppers marked this conversation as resolved.
if (to == nullptr) {
Expand Down
Loading