Skip to content

[Tools] Wait for Android JDWP application readiness #12589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
davidnguyen-tech wants to merge 2 commits into from
+730 −59
Closed

[Tools] Wait for Android JDWP application readiness #12589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1249123
Wait for Android JDWP application readiness
davidnguyen-tech Aug 29, 2026
0d2ce48
Extend Android JDWP readiness diagnostics
davidnguyen-tech Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions src/Xamarin.AndroidTools/Debugging/DebuggingExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ public static class DebuggingExtensions
// Twenty retries at 250 ms intervals allow up to five seconds for the process to appear.
const int GET_PID_RETRY_COUNT = 20;
const int WAIT_BEFORE_RETRY_GET_PID = 250;
const int WAIT_FOR_DEBUGGER_TO_ATTACH_MS = 1400;
internal static readonly TimeSpan WaitForDebuggerReadinessTimeout = TimeSpan.FromSeconds (30);

/// <summary>
/// Starts the process debugging using the given execution configuration
Expand Down Expand Up @@ -181,10 +181,7 @@ public static async Task ConnectJdwpAsync(this AndroidDevice androidDevice, Exec
await AdbServer.Default.ForwardPort (androidDevice, "tcp", jdwpClient.Port, "jdwp", pid, token).ConfigureAwait (false);
try {
await jdwpClient.ConnectAsync (token).ConfigureAwait (false);

// Keep the Connection for 1300 milliseconds, otherwise the Android OS ignores the connection!
// https://github.com/aosp-mirror/platform_frameworks_base/blob/6b28a227400749f4f8ad1f56799370e7c2cab149/core/java/android/os/Debug.java#L101C50-L101C54
await Task.Delay (WAIT_FOR_DEBUGGER_TO_ATTACH_MS, token).ConfigureAwait (false);
await jdwpClient.WaitForDebuggerReadinessAsync (WaitForDebuggerReadinessTimeout, config.LogWiter, token).ConfigureAwait (false);

await jdwpClient.DisconnectAsync ().ConfigureAwait (false);
} finally {
Expand Down
26 changes: 26 additions & 0 deletions src/Xamarin.AndroidTools/Debugging/Java/DdmCommandPacket.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
using System;
using System.Buffers.Binary;
using System.Text;

namespace Xamarin.AndroidTools.Debugging.Java
{
internal class DdmCommandPacket : CommandPacket
{
public DdmCommandPacket (string chunkType, ReadOnlyMemory<byte> chunkData)
{
if (chunkType == null)
throw new ArgumentNullException (nameof (chunkType));
if (chunkType.Length != 4)
throw new ArgumentException ("DDM chunk types must contain exactly four ASCII characters.", nameof (chunkType));

CommandSet = 0xc7;
Command = 0x01;

var data = new byte [8 + chunkData.Length];
Encoding.ASCII.GetBytes (chunkType, 0, chunkType.Length, data, 0);
BinaryPrimitives.WriteInt32BigEndian (data.AsSpan (4, 4), chunkData.Length);
chunkData.CopyTo (data.AsMemory (8));
Data = data;
}
}
}
Loading
Loading