[build] Serialize pose detection projects - #1531
Merged
Merged
Conversation
Add a reusable build-order mapping that emits ordering-only ProjectReference items, preventing the pose detection projects from concurrently consuming their shared AAR. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Adds a build-order-only project-reference mechanism to the Binderator project template so specific ML Kit binding projects can be serialized during builds, avoiding concurrent access to shared generated artifacts (notably pose-detection-common).
Changes:
- Introduced a reusable mapping (
buildOrderProjectReferences) for “ordering-only” project references keyed by NuGet package ID. - Added an ordering edge so
Xamarin.Google.MLKit.PoseDetectionbuilds aftercom.google.mlkit.pose-detection-accurate. - Marked the ordering
ProjectReferenceas non-compilation/non-dependency impacting viaReferenceOutputAssembly="false"andPrivateAssets="all".
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Member
Author
|
@dalexsoto review |
jonathanpeppers
enabled auto-merge (squash)
August 20, 2026 18:07
dalexsoto
approved these changes
Aug 20, 2026
dalexsoto
left a comment
Member
There was a problem hiding this comment.
The generated build-only edge serializes Accurate before standard pose detection under parallel/static-graph builds without compile or NuGet dependency leakage, and exact-head CI validates both TFMs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
pose-detectionafterpose-detection-accurateso they do not concurrently consume the sharedpose-detection-commonAAR.ReferenceOutputAssembly="false"andPrivateAssets="all"so the ordering edge does not affect compilation or NuGet dependencies.Validation
dotnet cake build.cake --target=binderate --verbosity=minimal.Xamarin.Google.MLKit.PoseDetectionand confirmedPoseDetection.Accurateis absent from the generated.nuspecdependencies.