Skip to content

Categorize Entra integrated test as interactive #4510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
paulmedynski wants to merge 3 commits into
base: main
Choose a base branch
from
+4 −14
Draft

Categorize Entra integrated test as interactive #4510

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7bfbdaf
Clarify Entra integrated test failure
paulmedynski Aug 7, 2026
a268e13
Categorize Entra integrated test as interactive
paulmedynski Aug 7, 2026
ec17b6f
Normalize interactive test category casing
paulmedynski Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 3 additions & 13 deletions src/Microsoft.Data.SqlClient.Extensions/Azure/test/AADConnectionTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,19 +85,9 @@ public static void ActiveDirectoryDefaultMustPass()
ConnectAndDisconnect(connStr);
}

// This test works on main in the existing jobs (like Win22_Sql22), but
// fails in the Azure project tests on a similar agent/image:
//
// Failed Microsoft.Data.SqlClient.Extensions.Azure.Test.AADConnectionTest.ADIntegratedUsingSSPI [59 ms]
// Error Message:
// Microsoft.Data.SqlClient.SqlException : Failed to authenticate the user NT Authority\Anonymous Logon in Active Directory (Authentication=ActiveDirectoryIntegrated).
// Error code 0xget_user_name_failed
// Failed to acquire access token for ActiveDirectoryIntegrated: Failed to get user name.
//
// ActiveIssue tests can be filtered out of test runs on the dotnet CLI
// using the filter "category != failing".
//
[ActiveIssue("https://sqlclientdrivers.visualstudio.com/ADO.Net/_workitems/edit/45941")]
// This test requires a signed-in user identity configured for Entra Integrated
// authentication and is excluded from non-interactive test runs by default.
[Trait("Category", "interactive")]

@paulmedynski paulmedynski Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build.proj skips interactive tests by default, so this will not run in CI.

[ConditionalFact(
typeof(Config),
nameof(Config.SupportsIntegratedSecurity),
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.Data.SqlClient.Extensions/Azure/test/ActiveDirectoryInteractiveTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public ActiveDirectoryInteractiveTests(ITestOutputHelper output)
}

[Fact]
[Trait("Category", "Interactive")]

@paulmedynski paulmedynski Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency with the casing of our other traits.

[Trait("Category", "interactive")]
public async Task TestConnection()
{
string connectionString = new SqlConnectionStringBuilder()
Expand Down
Loading