[6.1.6] Fix macOS CI: trust microsoft/mssql-release tap for Homebrew 5.2+ (#4363)#4366
Open
github-actions[bot] wants to merge 1 commit into
Open
[6.1.6] Fix macOS CI: trust microsoft/mssql-release tap for Homebrew 5.2+ (#4363)#4366github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
…2+ (#4363) Homebrew 5.2.0 made untrusted-tap enforcement the default. After 'brew update' pulls in the new version, 'brew install mssql-tools18' is refused because the microsoft/mssql-release tap is untrusted. Add 'brew trust microsoft/mssql-release' after 'brew update' to explicitly trust the Microsoft tap (placed after update so the trust command is available even on older runner images). Add a fail-fast check after 'brew install mssql-tools18' to immediately abort with a clear error if sqlcmd is not on PATH, avoiding the 6-minute timeout loop.
paulmedynski
force-pushed
the
dev/automation/pr-4363-to-6.1.6
branch
from
f02acb0 to
c077d98
Compare
paulmedynski
changed the title
paulmedynski
added
the
Area\Engineering
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
paulmedynski
assigned
apoorvdeshmukh,
cheenamalhotra and
priyankatiwari08 and unassigned
benrr101 and
paulmedynski
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the macOS SQL Server CI setup step to accommodate Homebrew 5.2+ untrusted-tap enforcement and to fail fast when mssql-tools18 installation doesn’t provide sqlcmd, preventing long retry timeouts later in the script.
Changes:
- Add
brew trust microsoft/mssql-releaseafterbrew updatesomssql-tools18can be installed under Homebrew 5.2+ trust requirements. - Add an explicit post-install check to abort immediately with a clear error if
sqlcmdis not onPATH.
paulmedynski
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of #4363 to
release/6.1.Homebrew 5.2.0 made untrusted-tap enforcement the default. After
brew updatepulls in the new version,brew install mssql-tools18is refused because themicrosoft/mssql-releasetap is untrusted.Changes:
brew trust microsoft/mssql-releaseafterbrew updateto explicitly trust the Microsoft tap (placed after update so the trust command is available even on older runner images).brew install mssql-tools18to immediately abort with a clear error if sqlcmd is not on PATH, avoiding the 6-minute timeout loop.Re-implemented (not cherry-picked) due to context differences on
release/6.1.