Add configurable idle connection timeout (ADO #39970) by priyankatiwari08 · Pull Request #4295 · dotnet/SqlClient

priyankatiwari08 · 2026-05-19T10:11:41Z

Adds a configurable idle connection timeout for pooled SqlConnection instances.

Compatibility and behavior:

The existing default remains unchanged: IdleTimeout defaults to 300 seconds.
Idle-expiration behavior is gated by Switch.Microsoft.Data.SqlClient.UseLegacyIdleTimeoutBehavior, which defaults to true so current behavior is preserved unless the switch is disabled.
When the legacy switch is disabled, the configured IdleTimeout controls when pooled connections are considered idle and eligible for expiration.

Additional changes:

Updates both pool implementations to honor the new behavior consistently.
Adds tests for parsing, legacy compatibility, and idle-expiration behavior.

Implements spec User Stories 1, 2, 4 + FR-009 of US3 from specs/003-pool-idle-timeout/spec.md. Adds 'Connection Idle Timeout' keyword (synonym: 'Pool Idle Timeout') exposed via SqlConnectionStringBuilder.IdleTimeout. When > 0, connections that have sat idle in the pool longer than the configured number of seconds are discarded on retrieval and a fresh connection is returned. Default 0 (disabled) matches the existing convention used by LoadBalanceTimeout and ConnectionLifetime. Covers both pool designs (ChannelDbConnectionPool, WaitHandleDbConnectionPool). Deferred to follow-up: proactive timer sweep (FR-008, FR-010) which the spec assumes is built on top of the pruning feature (#37338).

Copilot

Pull request overview

Adds a new pooling-related connection-string keyword, Connection Idle Timeout (synonym: Pool Idle Timeout), enabling lazy eviction of pooled connections that have sat idle longer than the configured number of seconds. This targets stale/half-open pooled connections (e.g., behind firewalls/load balancers) by discarding expired idle connections on the retrieval path in both pool implementations.

Changes:

Introduces Connection Idle Timeout parsing + SqlConnectionStringBuilder.IdleTimeout property (default 0 disables).
Tracks per-connection idle timestamp (DbConnectionInternal.IdleSinceUtc) and stamps it on return-to-pool; evicts idle-expired connections on retrieval in both pool designs.
Adds unit/functional tests for the new builder keyword/property and Channel pool idle-expiry behavior.

Reviewed changes

Copilot reviewed 15 out of 16 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
doc/snippets/Microsoft.Data.SqlClient/SqlConnectionStringBuilder.xml	Adds XML doc snippet for `SqlConnectionStringBuilder.IdleTimeout`.
src/Microsoft.Data.SqlClient/ref/Microsoft.Data.SqlClient.cs	Updates reference assembly surface with `IdleTimeout` property.
src/Microsoft.Data.SqlClient/src/Microsoft/Data/Common/ConnectionString/DbConnectionStringKeywords.cs	Adds canonical keyword string `Connection Idle Timeout`.
src/Microsoft.Data.SqlClient/src/Microsoft/Data/Common/ConnectionString/DbConnectionStringDefaults.cs	Adds default `IdleTimeout = 0`.
src/Microsoft.Data.SqlClient/src/Microsoft/Data/Common/ConnectionString/DbConnectionStringSynonyms.cs	Adds synonym `pool idle timeout`.
src/Microsoft.Data.SqlClient/src/Microsoft/Data/ProviderBase/DbConnectionInternal.cs	Adds `IdleSinceUtc` tracking + `MarkPooledIdle()` stamping helper.
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/ChannelDbConnectionPool.cs	Stamps idle time on return and adds idle-expiry check in `IsLiveConnection`.
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/DbConnectionPoolOptions.cs	Adds `IdleTimeout` option (as `TimeSpan`) to pool group options.
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/WaitHandleDbConnectionPool.cs	Stamps idle time on return and adds `IsIdleExpired` check at retrieval sites.
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnectionFactory.cs	Wires parsed idle-timeout option into pool group options creation.
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnectionOptions.cs	Parses/validates idle-timeout integer from connection string.
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnectionStringBuilder.cs	Adds `IdleTimeout` keyword/property support + synonym mapping.
src/Microsoft.Data.SqlClient/src/Resources/Strings.resx	Adds localized description string for the new keyword/property.
src/Microsoft.Data.SqlClient/src/Resources/Strings.Designer.cs	Regenerates resource accessor for `DbConnectionString_IdleTimeout`.
src/Microsoft.Data.SqlClient/tests/UnitTests/ConnectionPool/ChannelDbConnectionPoolTest.cs	Adds unit tests for Channel pool idle-timeout behavior and stamping.
src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlConnectionStringBuilderTest.cs	Adds functional tests for keyword parsing, round-trip, default, and invalid values.

Files not reviewed (1)

src/Microsoft.Data.SqlClient/src/Resources/Strings.Designer.cs: Language not supported

Comments suppressed due to low confidence (2)

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/ChannelDbConnectionPool.cs:445

The comment says that when IdleSinceUtc is the default (DateTime.MinValue) the idle-timeout check is a no-op and indicates the connection has never been pooled. In this PR IdleSinceUtc is initialized to CreateTime in DbConnectionInternal, so it will not be DateTime.MinValue, and even if it were, the current comparison would not be a no-op. Please update/remove this comment to match the actual semantics (e.g., describe the create-time initialization and that the check applies to any connection read from the idle channel).

            // Connection has been sitting idle longer than the configured idle timeout.
            // IdleSinceUtc is stamped by ReturnInternalConnection on each return; if it is the default
            // (DateTime.MinValue), the connection has never been pooled yet and the check is a no-op.
            TimeSpan idleTimeout = PoolGroupOptions.IdleTimeout;

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/WaitHandleDbConnectionPool.cs:1351

Idle-timeout enforcement was added to the legacy WaitHandleDbConnectionPool (new IsIdleExpired check + MarkPooledIdle stamping), but there doesn’t appear to be any unit test coverage exercising this path (existing idle-timeout unit tests are only for ChannelDbConnectionPool). Please add at least one focused test validating that an idle-expired connection is discarded and replaced in WaitHandleDbConnectionPool, and that IdleTimeout==0 leaves behavior unchanged.

        /// <summary>
        /// Returns true when the supplied connection has been sitting idle in the pool longer than the
        /// configured <see cref="DbConnectionPoolGroupOptions.IdleTimeout"/>. Returns false when idle timeout
        /// is disabled (zero).
        /// </summary>
        private bool IsIdleExpired(DbConnectionInternal obj)
        {
            TimeSpan idleTimeout = PoolGroupOptions.IdleTimeout;
            return idleTimeout != TimeSpan.Zero && DateTime.UtcNow > obj.IdleSinceUtc + idleTimeout;
        }

codecov · 2026-05-19T11:23:02Z

Codecov Report

❌ Patch coverage is 89.77273% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.18%. Comparing base (f50d21c) to head (b52495f).
⚠️ Report is 5 commits behind head on main.

Files with missing lines	Patch %	Lines
...lient/ConnectionPool/WaitHandleDbConnectionPool.cs	84.37%	5 Missing ⚠️
...qlClient/ConnectionPool/DbConnectionPoolOptions.cs	80.00%	2 Missing ⚠️
...c/Microsoft/Data/SqlClient/SqlConnectionOptions.cs	71.42%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4295      +/-   ##
==========================================
- Coverage   65.59%   64.18%   -1.42%     
==========================================
  Files         285      280       -5     
  Lines       43311    66244   +22933     
==========================================
+ Hits        28412    42521   +14109     
- Misses      14899    23723    +8824

Flag	Coverage Δ
CI-SqlClient	`?`
PR-SqlClient-Project	`64.18% <89.77%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- Fix stale comment in ChannelDbConnectionPool.IsLiveConnection: IdleSinceUtc is initialized to CreateTime, not DateTime.MinValue. - Add WaitHandleDbConnectionPoolIdleTimeoutTest mirroring the existing channel-pool idle-timeout coverage (stamp on return, zero disables expiry, expired connection is replaced, fresh connection is reused).

Copilot

Pull request overview

Copilot reviewed 16 out of 17 changed files in this pull request and generated 1 comment.

Files not reviewed (1)

src/Microsoft.Data.SqlClient/src/Resources/Strings.Designer.cs: Language not supported

- Skip MarkPooledIdle on return when IdleTimeout == TimeSpan.Zero so the default config has no per-return DateTime.UtcNow on the hot path. Applies to ChannelDbConnectionPool.ReturnInternalConnection and WaitHandleDbConnectionPool.PutNewObject. - Stamp IdleSinceUtc when returning a connection into the transacted pool (WaitHandleDbConnectionPool.DeactivateObject before TransactedConnectionPool.PutTransactedObject) so idle expiry on the next retrieval measures time spent parked in the transacted pool, not time since create-time / last general-pool return. - Add 2 WaitHandle pool tests covering the new behavior: IdleTimeout_TransactedPool_StampsOnReturn and IdleTimeout_Zero_DoesNotStampOnReturn.

Copilot

Pull request overview

Copilot reviewed 16 out of 17 changed files in this pull request and generated 1 comment.

Files not reviewed (1)

src/Microsoft.Data.SqlClient/src/Resources/Strings.Designer.cs: Language not supported

Comments suppressed due to low confidence (2)

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/WaitHandleDbConnectionPool.cs:1043

The idle-timeout eviction check is evaluated after obj.IsConnectionAlive(). For long-idle pooled connections, IsConnectionAlive() may perform an expensive SNI-level liveness probe; if the connection is already idle-expired, that work is unnecessary. Consider checking IsIdleExpired(obj) first (or reordering the condition) so expired connections are discarded without doing a liveness check.

This issue also appears on line 1218 of the same file.

                                if ((obj != null) && (!obj.IsConnectionAlive() || IsIdleExpired(obj)))
                                {
                                    SqlClientEventSource.Log.TryPoolerTraceEvent("<prov.DbConnectionPool.GetConnection|RES|CPOOL> {0}, Connection {1}, found dead and removed.", Id, obj.ObjectID);
                                    DestroyObject(obj);
                                    obj = null;     // Setting to null in case creating a new object fails

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/WaitHandleDbConnectionPool.cs:1222

Similar to the general-pool path: in the transacted-pool retrieval, the code calls obj.IsConnectionAlive() before IsIdleExpired(obj). Since IsConnectionAlive() can trigger an SNI liveness probe for idle connections, consider checking IsIdleExpired(obj) first to avoid extra work when the idle-timeout policy is what causes the connection to be recycled.

                    else if (!obj.IsConnectionAlive() || IsIdleExpired(obj))
                    {
                        SqlClientEventSource.Log.TryPoolerTraceEvent("<prov.DbConnectionPool.GetFromTransactedPool|RES|CPOOL> {0}, Connection {1}, found dead and removed.", Id, obj.ObjectID);
                        DestroyObject(obj);
                        obj = null;

…sacted idle handling - Default Connection Idle Timeout 0 -> 300 (5 min, matches Npgsql); 0 disables. - Remove 'Pool Idle Timeout' synonym; the canonical keyword is the only accepted form. - Make idleTimeout a required parameter on DbConnectionPoolGroupOptions; defaults now live in DbConnectionStringDefaults. - Use TimeSpan.FromSeconds for the ctor body conversion. - WaitHandle pool: drop MarkPooledIdle() on transacted-pool return and remove the idle-expiry check on transacted-pool retrieval (transacting connections must never be proactively closed). - WaitHandle pool: reorder general-pool retrieval to check idle expiry before the liveness probe; derive _cleanupWait from IdleTimeout when set. - Channel pool: reorder IsLiveConnection so the idle check runs before IsConnectionAlive(). - Tests, doc snippet, and release notes updated accordingly.

priyankatiwari08 · 2026-05-26T15:40:25Z

All review feedback has been addressed:

Default value for Connection Idle Timeout is now 300 (5 min, matches Npgsql); 0 disables idle expiration.
The Pool Idle Timeout synonym has been removed; only the canonical keyword is accepted.
idleTimeout is now a required parameter in DbConnectionPoolGroupOptions.
The constructor uses TimeSpan.FromSeconds as suggested.
WaitHandle pool: dropped MarkPooledIdle() on transacted-pool return and removed idle-expiry check on transacted-pool retrieval (transacting connections are never proactively closed).
WaitHandle pool: general-pool retrieval now checks idle expiry before liveness; _cleanupWait is driven by IdleTimeout (random fallback when 0).
Channel pool: IsLiveConnection now checks idle expiry before liveness.
All affected tests and docs updated; release notes entry added.
All unit and functional tests pass (except 5 pre-existing AlwaysEncrypted admin-rights failures).

Ready for re-review. Please confirm if any further changes are needed.

Copilot

Pull request overview

Copilot reviewed 17 out of 18 changed files in this pull request and generated 5 comments.

Files not reviewed (1)

src/Microsoft.Data.SqlClient/src/Resources/Strings.Designer.cs: Language not supported

mdaigle

Thanks for making those changes. I have a few more updates that I'd like to see. Otherwise it's very close.

Copilot

Pull request overview

Copilot reviewed 20 out of 21 changed files in this pull request and generated 1 comment.

Files not reviewed (1)

src/Microsoft.Data.SqlClient/src/Resources/Strings.Designer.cs: Language not supported

…ehavior switch and tighten idle-timeout test coverage - Delete redundant IdleTimeout_DefaultIsZero_DisablesExpiry from ChannelDbConnectionPoolTest. The 'default' framing was misleading (the builder-layer default is 300, not 0) and the zero-as-argument path is already covered by IdleTimeout_PoolGroupOptions_ConvertsSecondsToTimeSpan and IdleTimeout_Zero_DoesNotExpire. - Add IdleTimeout_LegacySwitch_SuppressesEviction to both ChannelDbConnectionPoolTest and WaitHandleDbConnectionPoolIdleTimeoutTest. Flips UseLegacyIdleTimeoutBehavior=true via LocalAppContextSwitchesHelper, back-dates ReturnedTime well past the 1-second timeout, and asserts the connection is still reused. Closes the coverage gap on switch gating in both pool implementations. - Document the gating in the public surfaces: extend SqlConnectionStringBuilder.xml <remarks> with a paragraph describing the Switch.Microsoft.Data.SqlClient.UseLegacyIdleTimeoutBehavior AppContext switch (defaults to true), and the three opt-out mechanisms (AppContext.SetSwitch, <RuntimeHostConfigurationOption>, runtimeconfig.json). Mirror the gating note in DbConnectionString_IdleTimeout in Strings.resx and the auto-generated Strings.Designer.cs accessor so the [ResDescription] surfaced in property grids matches.

…ryGetConnection in shutdown tests PR dotnet#4295 (merged to main) added a required TimeoutTimer parameter to ChannelDbConnectionPool.TryGetConnection. The shutdown tests added in this PR still call the pre-dotnet#4295 3-arg overload, which compiles locally against PoolShutdown's older base but fails in the CI pipeline because the pipeline merges this PR's head into the post-dotnet#4295 main. Pass TimeoutTimer.StartNew(TimeSpan.FromSeconds(15)) at all 5 call sites to match the new signature.

… and SetReturnedTime rename - WaitHandleDbConnectionPool ctor: collapse the three _cleanupWait branches into two (legacy-switch OR IdleTimeout==Zero -> historical 2-4 min window; else use configured timeout/2) per Paul's suggestion, and floor the new-behavior period at 1000 ms so small IdleTimeout values don't schedule a sub-second timer. - WaitHandleDbConnectionPool.CleanupCallback: gate both the destroy and the new->old age sweeps on a single `idleEvictionDisabled'' check (`!UseLegacyIdleTimeoutBehavior && IdleTimeout == Zero'') so the `OFF + 0 = disabled entirely'' case is honored. The MinPoolSize-floor re-queue below the gates still runs. - Rename DbConnectionInternal.ReturnedToPool -> SetReturnedTime and update both call sites (WaitHandle, Channel) and the related comment. The name now describes the mechanism (the connection stamps its returned time) and reads cleanly when the pool decides to skip the call because nothing will read the stamp. - Add WaitHandleDbConnectionPoolIdleTimeoutTest IdleTimeout_LegacyOff_Zero_CleanupCallbackDoesNotEvict covering the new CleanupCallback gate. Reaches the private method via reflection.

Copilot

Pull request overview

Copilot reviewed 20 out of 21 changed files in this pull request and generated no new comments.

Files not reviewed (1)

src/Microsoft.Data.SqlClient/src/Resources/Strings.Designer.cs: Language not supported

… idleTimeout: 0 to DbConnectionPoolGroupOptions ctor

…ectionPoolGroupOptions ctor (required after PR 4295)

Copilot

Pull request overview

Copilot reviewed 21 out of 22 changed files in this pull request and generated 2 comments.

Files not reviewed (1)

src/Microsoft.Data.SqlClient/src/Resources/Strings.Designer.cs: Language not supported

priyankatiwari08 · 2026-06-10T19:12:40Z

+                    // the period at 1 second so small IdleTimeout values (e.g. 1s) don't schedule a
+                    // sub-second timer that wakes the threadpool just to walk empty stacks.
+                    long cleanupWaitMilliseconds = (long)idleTimeout.TotalMilliseconds / 2;
+                    cleanupWaitMilliseconds = Math.Max(cleanupWaitMilliseconds, 1000);
+                    _cleanupWait = cleanupWaitMilliseconds >= int.MaxValue ? int.MaxValue : (int)cleanupWaitMilliseconds;


Fixed in e999310.

Inside CleanupCallback's destroy loop, after popping from _stackOld we now consult per-connection ReturnedTime via IsIdleExpired(obj) before destroying. If the new behaviour is enabled and the connection has not yet exceeded IdleTimeout, we push it back onto _stackOld, release the semaphore count, and break out of the tick — the next tick reconsiders. Because _stackOld is age-ordered, anything still on it after the youngest survivor is also younger and can't be expired either, so break (rather than continue) is correct and avoids wasted work.

Legacy behaviour (UseLegacyIdleTimeoutBehavior = true or IdleTimeout = 0) is untouched and continues to destroy unconditionally as before, preserving bit-for-bit historical behaviour.

The push-back + Release(1) keeps the PoolSemaphore.Count == IdleCount invariant intact: the connection is still tracked in _objectList, so dropping it would leak a phantom entry from Count.

@mdaigle @paulmedynski - Could you please review this bit if this seems correct or should I keep the original logic.

That only holds true when stackOld was empty. If we transition items from stackNew into a non-empty stackOld, then everything already existing in stackOld is necessarily older. The comment near this code calls out the same thing, stackOld isn't age ordered.

I think there are degenerate cases where we could end up not pruning anything for a long time (if the max pool size is large), and it adds complexity to the pruning process that's hard to reason about. I'd prefer to prune more aggressively; we've already documented it as a best effort and customers can bump up the timeout if needed.

…on IsIdleExpired With _cleanupWait = IdleTimeout/2, the legacy two-stack generational sweep in CleanupCallback could destroy a connection from _stackOld after as little as ~IdleTimeout/2 of real idle time, violating the new contract that connections are only destroyed once their idle age exceeds IdleTimeout. Add a per-connection IsIdleExpired check inside the destroy loop: when the new behaviour is enabled and the popped connection has not yet exceeded IdleTimeout, push it back onto _stackOld, release the semaphore count, and break out of the tick. The next cleanup tick reconsiders. Legacy behaviour (switch on or IdleTimeout = 0) is untouched and continues to destroy unconditionally as before.

Copilot

Pull request overview

Copilot reviewed 21 out of 22 changed files in this pull request and generated 1 comment.

Files not reviewed (1)

src/Microsoft.Data.SqlClient/src/Resources/Strings.Designer.cs: Language not supported

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 21 out of 22 changed files in this pull request and generated 4 comments.

Files not reviewed (1)

src/Microsoft.Data.SqlClient/src/Resources/Strings.Designer.cs: Language not supported

+        /// <summary>
+        /// The maximum time a pooled connection can sit unused (idle) in the pool before it is discarded
+        /// on the next retrieval attempt. <see cref="TimeSpan.Zero"/> disables idle expiration.
+        /// </summary>


paulmedynski · 2026-06-11T13:50:42Z

+            // When the new idle-timeout behaviour is enabled and IdleTimeout is 0, idle eviction is
+            // disabled entirely: skip the generational destroy/age-into-old-stack sweep and only run
+            // the MinPoolSize floor maintenance below.
+            bool idleEvictionDisabled =


You only ever check the negative of this bool, so let's flip its meaning to idleEvictionEnabled. Then the computation becomes easier to understand as well.

Copilot AI review requested due to automatic review settings May 19, 2026 10:11

github-project-automation Bot added this to SqlClient Board May 19, 2026

github-project-automation Bot moved this to To triage in SqlClient Board May 19, 2026

Copilot started reviewing on behalf of priyankatiwari08 May 19, 2026 10:12 View session

Copilot AI reviewed May 19, 2026

View reviewed changes

Comment thread ...rosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/ChannelDbConnectionPool.cs Outdated

Comment thread ...oft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/WaitHandleDbConnectionPool.cs Outdated

priyankatiwari08 marked this pull request as ready for review May 21, 2026 11:20

priyankatiwari08 requested a review from a team as a code owner May 21, 2026 11:20

Copilot AI review requested due to automatic review settings May 21, 2026 11:20

Copilot started reviewing on behalf of priyankatiwari08 May 21, 2026 11:21 View session

Copilot AI reviewed May 21, 2026

View reviewed changes

Comment thread ...oft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/WaitHandleDbConnectionPool.cs Outdated

priyankatiwari08 added this to the 7.1.0-preview2 milestone May 21, 2026

priyankatiwari08 requested a review from Copilot May 21, 2026 11:39

Copilot started reviewing on behalf of priyankatiwari08 May 21, 2026 11:40 View session

Copilot AI reviewed May 21, 2026

View reviewed changes

Comment thread ...rosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/ChannelDbConnectionPool.cs Outdated

paulmedynski self-assigned this May 21, 2026

paulmedynski added the Area\Connection Pooling Use this label to tag issues that apply to problems with connection pool. label May 21, 2026

paulmedynski moved this from To triage to In review in SqlClient Board May 21, 2026

mdaigle self-assigned this May 21, 2026

mdaigle requested changes May 22, 2026

View reviewed changes

github-project-automation Bot moved this from In review to Waiting for customer in SqlClient Board May 22, 2026

priyankatiwari08 requested a review from Copilot May 26, 2026 15:40

Copilot started reviewing on behalf of priyankatiwari08 May 26, 2026 15:41 View session

Copilot AI reviewed May 26, 2026

View reviewed changes

mdaigle requested changes May 26, 2026

View reviewed changes

priyankatiwari08 force-pushed the feature/idle-connection-timeout-pr1 branch from 7b13305 to 126e272 Compare June 5, 2026 13:08

Copilot started reviewing on behalf of priyankatiwari08 June 5, 2026 13:08 View session

Copilot AI reviewed Jun 5, 2026

View reviewed changes

Comment thread ...oft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/WaitHandleDbConnectionPool.cs

priyankatiwari08 force-pushed the feature/idle-connection-timeout-pr1 branch from 126e272 to 0cf4d4a Compare June 5, 2026 13:19

paulmedynski requested changes Jun 5, 2026

View reviewed changes

Comment thread ...oft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/WaitHandleDbConnectionPool.cs Outdated

Comment thread ...oft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/WaitHandleDbConnectionPool.cs Outdated

github-project-automation Bot moved this from In progress to Waiting for customer in SqlClient Board Jun 5, 2026

mdaigle moved this from Waiting for customer to In review in SqlClient Board Jun 5, 2026

priyankatiwari08 marked this pull request as draft June 9, 2026 11:00

Copilot AI review requested due to automatic review settings June 10, 2026 12:49

Copilot started reviewing on behalf of priyankatiwari08 June 10, 2026 12:49 View session

Copilot AI reviewed Jun 10, 2026

View reviewed changes

priyankatiwari08 added 2 commits June 10, 2026 22:49

Merge origin/main; fix new ChannelDbConnectionPoolPruningTest to pass…

182b596

… idleTimeout: 0 to DbConnectionPoolGroupOptions ctor

Fix ChannelDbConnectionPoolPruningTest: pass idleTimeout: 0 to DbConn…

f78fac0

…ectionPoolGroupOptions ctor (required after PR 4295)

Copilot AI review requested due to automatic review settings June 10, 2026 17:31

Copilot started reviewing on behalf of priyankatiwari08 June 10, 2026 17:31 View session

Copilot AI reviewed Jun 10, 2026

View reviewed changes

priyankatiwari08 marked this pull request as ready for review June 11, 2026 08:05

priyankatiwari08 requested review from Copilot and paulmedynski June 11, 2026 08:05

Copilot started reviewing on behalf of priyankatiwari08 June 11, 2026 08:06 View session

Copilot AI reviewed Jun 11, 2026

View reviewed changes

Comment thread ...oft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/WaitHandleDbConnectionPool.cs Outdated

Potential fix for pull request finding

b52495f

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings June 11, 2026 08:43

Copilot started reviewing on behalf of priyankatiwari08 June 11, 2026 08:43 View session

Copilot AI reviewed Jun 11, 2026

View reviewed changes

paulmedynski reviewed Jun 11, 2026

View reviewed changes

Conversation

priyankatiwari08 commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

priyankatiwari08 commented May 26, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mdaigle left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

priyankatiwari08 Jun 10, 2026

Choose a reason for hiding this comment

Uh oh!

mdaigle Jun 11, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

priyankatiwari08 commented May 19, 2026 •

edited

Loading

codecov Bot commented May 19, 2026 •

edited

Loading