Conversation
33 tasks
guardrex
force-pushed
the
guardrex/fundamentals-startup
branch
from
September 8, 2026 11:44
2a0ed77 to
f8c5978
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The updated aspnetcore/fundamentals/startup.md content includes a broken code sample and a malformed link that should be corrected before merge.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates the App startup and related Fundamentals documentation to better explain the modern hosting/startup flow, refresh cross-links to the updated startup filter section, and remove legacy in-repo sample assets that no longer appear to be needed.
Changes:
- Overhauled
fundamentals/startupguidance (Program-based startup flow, startup filters section, and related links). - Updated cross-references in integration testing + migration + configuration docs to point at the new/updated heading anchors.
- Added a
ServerReady/startup-time note under the loggingEventSourceprovider and refreshedms.datemetadata on touched articles.
File summaries
| File | Description |
|---|---|
| aspnetcore/fundamentals/startup.md | Startup article overhaul; adds/adjusts sections and anchors referenced elsewhere. |
| aspnetcore/fundamentals/logging/index.md | Adds ServerReady note under EventSource; updates metadata. |
| aspnetcore/fundamentals/configuration/index.md | Updates cross-link to the startup convenience-methods section anchor. |
| aspnetcore/test/integration-tests.md | Updates reference to use IStartupFilter and points to the new startup filters anchor; updates metadata. |
| aspnetcore/test/integration-tests/includes/integration-tests7.md | Same cross-link update for .NET 7 include. |
| aspnetcore/test/integration-tests/includes/integration-tests8.md | Same cross-link update for .NET 8 include. |
| aspnetcore/test/integration-tests/includes/integration-tests9.md | Same cross-link update for .NET 9 include. |
| aspnetcore/migration/50-to-60.md | Removes legacy named anchors and updates a heading used for linking. |
| aspnetcore/migration/50-to-60-samples.md | Updates link to the new “New hosting model” heading anchor. |
| aspnetcore/migration/31-to-60.md | Updates link to the renamed “Use a Startup class…” heading anchor. |
| aspnetcore/fundamentals/startup/** (legacy samples) | Removes older startup sample snapshots and bundled static assets under versioned sample folders. |
Review details
- Files reviewed: 134/174 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
guardrex
marked this pull request as ready for review
September 9, 2026 19:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #37590
Addresses #34356
Notes
Ilona ... Would you see if I made technical mistakes or left anything important out? The main focus is the new content for >=6.0 at the top of the Startup article (on the diff here). It's not very much content, and I hope it won't take you much time to look over.
Wade ... Per our brief convo on the Fundamentals overview PR, we might need to discuss these in-repo samples further. I don't understand the concern about dropping them. IMO, the tutorials, such as the Blazor tutorials, are the best way to walk a dev through working code for base case learning scenarios. Then, advanced samples exist for difficult concepts that run under recent/current .NET versions with modern tooling and C# language versions that are easily accessible for inspection and download.
Startupclass coverage only appearing for <6.0 in spite of current support, I think that was a management decision because the PU wants devs to focus on the minimal hosting model. We have some current version content to cross-link the article's 5.0 version if a dev is upgrading an app and looking for the coverage. I left this paradigm in place for theStartupclass coverage.ServerReady/startup performance is worth a mention, but I place a new, short section on it in the Logging overview (as anEventSourcesubsection) and cross-link to it there.Internal previews
Build report