Skip to content

default historical now True by default for get_job #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pmrich merged 1 commit into from
Apr 9, 2026
Merged

default historical now True by default for get_job #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/routers/compute/compute.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ async def get_job_status(
job_id: str,
request: Request,
user: User = Depends(router.current_user),
historical: StrictHTTPBool | None = Query(default=False, description="Whether to include historical jobs. Defaults to false"),
historical: StrictHTTPBool | None = Query(default=True, description="Whether to include historical jobs. Defaults to true"),
include_spec: StrictHTTPBool | None = Query(default=False, description="Whether to include the job specification. Defaults to false"),
_forbid=Depends(forbidExtraQueryParams("historical", "include_spec")),
):
Expand Down
2 changes: 1 addition & 1 deletion app/routers/compute/facility_adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ async def get_job(
resource: status_models.Resource,
user: User,
job_id: str,
historical: bool = False,
historical: bool = True,
include_spec: bool = False,
) -> compute_models.Job:
pass
Expand Down
Loading