Skip to content

fix(cli): remove unused backend flag from compose up - #1037

Open
VedantMadane wants to merge 1 commit into
docker:mainfrom
VedantMadane:fix-compose-backend-flag
Open

fix(cli): remove unused backend flag from compose up#1037
VedantMadane wants to merge 1 commit into
docker:mainfrom
VedantMadane:fix-compose-backend-flag

Conversation

@VedantMadane

Copy link
Copy Markdown
Contributor

Summary

Fixes #1036

In cmd/cli/commands/compose.go,
ewUpCommand() defined a --backend flag variable �ackend but never passed it to desktopClient.ConfigureBackend(...). As a result, passing --backend was a silent no-op while compose metadata still advertised --backend parameter to UI consumers.

This PR removes the dead --backend flag variable and flag binding from
ewUpCommand() and removes the unused llamacpp import.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

compose up: --backend flag is accepted but never applied

1 participant