docs: show network=host for the docker-container builder - #25864
Open
locker95 wants to merge 1 commit into
Open
Conversation
The custom-network section only had a user-defined overlay. Reaching a host service needs network=host, which the default docker driver cannot do. Signed-off-by: Dean Chen <862469039@qq.com>
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
Bot
added
the
area/build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docker-container driver page showed a user-defined overlay, but not the host-network case. That's the usual way to reach something on the host (local registry, etc.) when the default docker driver cannot see overlay networks.
@netlify /build/builders/drivers/docker-container/
Closes docker/buildx#1437