docs: surface the cgroup v2 limitation earlier in runtime metrics#24914
Open
Rohan5commit wants to merge 1 commit intodocker:mainfrom
Open
docs: surface the cgroup v2 limitation earlier in runtime metrics#24914Rohan5commit wants to merge 1 commit intodocker:mainfrom
Rohan5commit wants to merge 1 commit intodocker:mainfrom
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
/review |
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
The change is focused and accurate. It surfaces the cgroup v2 limitation earlier on the page by adding a callout near the distribution list, renames the detailed metrics heading to clarify it covers cgroup v1, and rewrites the accompanying NOTE to be more actionable. Technical claims (controller file globs memory.*, cpu.*, io.*) are correct, no Vale violations were found, and line lengths are within limits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related issues or tickets
Guideline alignment
docs/CONTRIBUTING.mdValidation
docker buildx bake validate) because this is a docs-only clarificationReviews