Flatten alpha on selection bg tokens before applying themes#37
Merged
Conversation
Themes like Selenized Dark set list.activeSelectionBackground to a
translucent color (e.g. #0096f588) because VSCode renders it as an
overlay on the sidebar. MouseTerm uses the same token as a solid
AppBar / tab fill, so whatever sat behind the surface bled through —
on macOS that produced a bright cyan AppBar in focused state.
Composite list.{active,inactive}SelectionBackground over
sideBar.background in applyTheme so the materialized vars are opaque
and match what VSCode shows in the file tree.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Deploying mouseterm with
|
| Latest commit: |
01c3075
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ddfcdf45.mouseterm.pages.dev |
| Branch Preview URL: | https://fix-flatten-selection-alpha.mouseterm.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
list.activeSelectionBackgroundwith alpha (e.g.#0096f588) because VSCode renders it as an overlay on the sidebar. MouseTerm uses the same token as a solid AppBar / tab fill, so whatever sat behind the surface bled through — on macOS that produced a bright cyan AppBar in focused state.flatten-alpha.tshelper compositeslist.{active,inactive}SelectionBackgroundoversideBar.background(the surface VSCode itself overlays them on) insideapplyTheme, so the materialized--vscode-*vars are opaque and match what VSCode shows in the file tree. Original alpha values are preserved ontheme.varsand the snapshot'sprovidedVarsfor diagnostics.Test plan
pnpm vitest run(304 tests pass, including 7 newflatten-alphatests covering opaque passthrough, short/long hex, rgba(), unparseable input, and the actual Selenized Dark case)pnpm tsc --noEmitcleanTerminalPaneHeader/TodoAlertDialogstill look correct in non-affected themes (Default Dark+, Monokai, etc.)🤖 Generated with Claude Code