Merged
Conversation
Drop the local navigator-platform check in AppBar in favor of the canonical IS_MAC export from lib/platform. Simplify useAppWindowFocused to mirror the fetch-then-listen pattern already used by WinControls — Tauri's onFocusChanged covers what the redundant DOM focus/blur listeners were doing. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Five button variants across AppBar (standalone) and the ThemePicker non-playground trigger (lib) shared the same compact "h-5, hover:bg-current/10" pattern with small deltas: icon-only vs labeled, window-control sizing, danger hover for the close button. Collapse them into a tailwind-variants primitive in design.tsx alongside popupButton. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The window close button hover should always be the native OS red (#b92a1b on white), not a theme-tinted error color. Drop the generic `tone: danger` variant in favor of a dedicated `windowClose` kind so the special-case colors live with their only consumer. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
tauri-build doesn't expand bundle.resources globs into rerun-if-changed entries, so editing standalone/sidecar/*.js doesn't rerun build.rs and the staged copy under target/<profile>/_up_/sidecar/ goes stale. That silently defeated the parent-PID watchdog from 8e60dd4: the source had the fix but already-built dev artifacts didn't, so newly-spawned sidecars still ran pre-watchdog code and got orphaned anyway.
useAppWindowFocused now calls appWindow.isFocused() and onFocusChanged(). Add stub implementations to the Tauri window mock so the AppBar story doesn't throw when rendered in Storybook/Chromatic. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Deploying mouseterm with
|
| Latest commit: |
935fd17
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5506dc3e.mouseterm.pages.dev |
| Branch Preview URL: | https://standalone-appbar-command-hi.mouseterm.pages.dev |
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Drops two tracking-normal resets and a Door title tracking-[0.02em] that weren't pulling weight, and routes the remaining 0.08em on the TODO pills through a single TODO_PILL_TRACKING_CLASS in design.tsx so both pill sites stay in sync. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.