Skip to content

Windows terminal selection#32

Merged
nedtwigg merged 3 commits intomainfrom
win-terminal
Apr 30, 2026
Merged

Windows terminal selection#32
nedtwigg merged 3 commits intomainfrom
win-terminal

Conversation

@nedtwigg
Copy link
Copy Markdown
Member

@nedtwigg nedtwigg commented Apr 30, 2026

  • fix orphan node process on standalone Windows
  • fix double-checkmarked terminal on Windows

nedtwigg and others added 3 commits April 29, 2026 16:56
Two shells can share an executable path but differ by args (e.g. Windows
PowerShell and Developer PowerShell for VS both run powershell.exe).
Comparing by path marked both as selected and produced duplicate React
keys. Compare by name instead.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
When the Tauri host crashes or is force-killed, stdin EOF isn't
reliably delivered to the Node sidecar on Windows, so it lingers
with its image loaded from %LOCALAPPDATA%\MouseTerm — which then
makes the directory un-removable for the next dogfood --install.

Two changes:
- Sidecar: poll the parent PID every 2s and self-exit when it's
  gone, as a backstop for the missed-EOF case.
- dogfood.sh: taskkill any leftover process before installing, and
  delete dir contents instead of the directory itself so a busy
  dir can't fail the whole install.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@nedtwigg nedtwigg merged commit 45ae756 into main Apr 30, 2026
3 checks passed
@nedtwigg nedtwigg deleted the win-terminal branch April 30, 2026 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant