Incremental SMT2: Add size limit to array element retrieval#8902
Draft
tautschnig wants to merge 1 commit intodiffblue:developfrom
Draft
Incremental SMT2: Add size limit to array element retrieval#8902tautschnig wants to merge 1 commit intodiffblue:developfrom
tautschnig wants to merge 1 commit intodiffblue:developfrom
Conversation
Add MAX_TRACE_ARRAY_SIZE (1000) threshold to get_expr for array_typet. When an array exceeds this size, return empty optional with a warning instead of enumerating all elements, which caused OOM for large arrays (e.g., __CPROVER_max_malloc_size = 2^23). The caller in get() already handles empty optional gracefully by falling back to returning the original expression. Also remove the no-new-smt exclusion tag from pointer-offset-01 test since this fix prevents the OOM that required the exclusion. Fixes: diffblue#8071
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add MAX_TRACE_ARRAY_SIZE (1000) threshold to get_expr for array_typet. When an array exceeds this size, return empty optional with a warning instead of enumerating all elements, which caused OOM for large arrays (e.g., __CPROVER_max_malloc_size = 2^23).
The caller in get() already handles empty optional gracefully by falling back to returning the original expression.
Also remove the no-new-smt exclusion tag from pointer-offset-01 test since this fix prevents the OOM that required the exclusion.
Fixes: #8071