Skip get_literals call for unbounded arrays with zero-width elements#8898
Draft
tautschnig wants to merge 1 commit intodiffblue:developfrom
Draft
Skip get_literals call for unbounded arrays with zero-width elements#8898tautschnig wants to merge 1 commit intodiffblue:developfrom
tautschnig wants to merge 1 commit intodiffblue:developfrom
Conversation
In convert_index, bv_width.get_width_opt(array_type) returns nullopt for unbounded arrays of zero-width elements (e.g., empty structs). The previous code used value_or(0), which passed width=0 to map.get_literals. If the identifier already existed in the boolbv_map with a non-zero literal_map size, the invariant map_entry.literal_map.size() == width would fail. Fix: guard both get_literals calls so they are only made when the array width is known. Add regression test for this scenario. Fixes: diffblue#8480 Co-authored-by: Michael Tautschnig <mt@debian.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In convert_index, bv_width.get_width_opt(array_type) returns nullopt for unbounded arrays of zero-width elements (e.g., empty structs). The previous code used value_or(0), which passed width=0 to map.get_literals. If the identifier already existed in the boolbv_map with a non-zero literal_map size, the invariant map_entry.literal_map.size() == width would fail.
Fix: guard both get_literals calls so they are only made when the array width is known. Add regression test for this scenario.
Fixes: #8480